问题
The following code fails on a MISRA check. The concrete error message is:
(MISRA-C:2004 10.1/R) The value of an expression of integer type shall not be implicitly converted to a different underlying type if it is not a conversion to a wider integer type of the same signedness
typedef enum _MyEnum { One, Two } MyEnum;
MyEnum MyVariable;
int foo(void)
{
int result = 1;
if (One == MyVariable) // fails here with MISRA-C:2004 10.1/R
{
result = 2;
}
return result;
}
- Why is the logical expression converted?
- What is converted here?
- Why does the code pass the MISRA check, when I swap
One
andMyVariable
?
Edit: The compiler is a TI "MSP430 C/C++ Compiler v4.0.0" with included MISRA rules check.
回答1:
I would suspect a compiler bug. What compiler are you using? This post mentions a compiler bug causing Misra 10.1/R failures when using TI's compiler.
回答2:
There is no bug in the MISRA checker, it behaves correctly. You get this error because the C standard is flawed and illogical.
There are two items:
One
is an enumeration constant. The standard §6.7.2.2/2 states that this shall be compatible withint
, no exceptions.MyVariable
is an enumerated type. The standard §6.7.7.2/4 states that this should be compatible with char, a signed integer type or an unsigned integer type. Which type that applies is implementation-defined behavior.
In your case, the implementation-defined enumerated type appears to be equal to unsigned int.
So the code attempts to implictly convert a variable of signed int to unsigned int, which is a violation of MISRA 2004 10.1.
MISRA-compliant code should be if (One == (MyEnum)MyVariable)
.
回答3:
I would suspect the compiler internally handles enums
as unsigned integer
, as long there is no negative value within the enum
.
来源:https://stackoverflow.com/questions/10582523/how-are-integer-types-converted-implicitly