Can't access my service in my controller (undefined)

问题

I am trying to create a service to do some AJAX requests. However, my service keeps getting undefined when I try to do something with it in my controllers. Here is my code.

I have found a lot of examples on here, and I've tried to follow a lot of them but no matter what I do my service keeps getting undefined.

My service:

MyApp.factory('myService', function($http) {

return {
    findAll: function() {
        return $http.get('/findAll')
        .then(function(result) {
            return result.data;
        });
    }
   }
});

My Controller:

MyApp.controller('UserController', ['$scope', '$http', 'myService', function($scope, $http, $log, myService) {

// Whatever I do with myService here it gets undefined.
//$scope.test = myService.findAll();
//myService.findAll();


}]);

I assume I don't inject it correctly but I can't see whats wrong. I'm fairly new to Angular so.. Any pointers would be appreciated.

回答1:

Remove $log from the injection. You are currently "naming" the myService service to $log and therefore myService inside the controller is undefined.

MyApp.controller('UserController', ['$scope', '$http', 'myService',
    function($scope, $http, myService) {

    // Whatever I do with myService here it gets undefined.
    //$scope.test = myService.findAll();
    //myService.findAll();
}]);

2nd solution
To avoid having to "name" the services like this it's acceptable to inject them without naming them.

MyApp.controller('UserController', function($scope, $http, myService) {

    // Whatever I do with myService here it gets undefined.
    //$scope.test = myService.findAll();
    //myService.findAll();
});

Just remember to remove the closing bracket aswell.

来源：https://stackoverflow.com/questions/27589490/cant-access-my-service-in-my-controller-undefined

标签

angularjs

angular-services