Appending to a file instead of overwritting the file everytime in VBScript

问题

I am just trying to make a log file here. I have tried doing something with OpenTextFile instead of CreateTextFile, but then it just writes nothing and I'm really not sure why and I'm having trouble finding the info I need.

'Nick Repella 10/29/13

'Needed in case object does not exist (outdated list)
On Error Resume Next

Function IsCompDisabled(strLine)
    Dim objComputer
    objComputer = "LDAP://cn="
    objComputer = objComputer & strLine
    objComputer = objComputer & ",ou=HIDDENOU,dc=HIDDENDC,dc=HIDDENDC,dc=HIDDENDC"
    IsCompDisabled = GetObject(objComputer).AccountDisabled
End Function 

'Set the file to read computer names from (Change C:\scripts\text.txt to the 
'target file)
Set objFileToRead = CreateObject("Scripting.FileSystemObject").OpenTextFile("C:\scripts\text.txt", 1)

Dim strLine

Do While Not objFileToRead.AtEndOfStream
    strLine = objFileToRead.ReadLine()
    If (IsCompDisabled(strLine) = True) Then
        outFile="c:\scripts\compDisableCheck.log"
        Set objFSO = CreateObject("Scripting.FileSystemObject")
        Set objFile = objFSO.CreateTextFile(outFile, True)
        objFile.Write strLine & "has been deleted"
        objFile.Close        
    Else
        WScript.Echo strLine & " computer is enabled no action taken"
    End If
Loop

MsgBox "Done"

回答1:

Study the docs carefully. Define ForAppending, .OpenTextfile(sFSpec, ForAppending, True) the output file before, and close it after the loop.

(UNTESTED) code:

Option Explicit

Const ForAppending = 8

'No global OERN

'Function to tell if the computer is disabled
Function IsCompDisabled( strLine )
    ' type prefix fraud!
    Dim objComputer
    objComputer = "LDAP://cn="
    objComputer = objComputer & strLine
    objComputer = objComputer & ",ou=HIDDENOU,dc=HIDDENDC,dc=HIDDENDC,dc=HIDDENDC"
  ' Needed  H E R E  in case object does not exist (outdated list)
  On Error Resume Next
    IsCompDisabled = GetObject(objComputer).AccountDisabled
    ' should be logged; pass otp file as parameter
  On Error GoTo 0
End Function

'Set the file to read computer names from (Change C:\scripts\text.txt to the target file)
Dim oFS : Set oFS = CreateObject("Scripting.FileSystemObject")
Dim objFileToRead : Set objFileToRead = goFS.OpenTextFile("C:\scripts\text.txt") ' Using defaults, no magiv number
' delete otp file here, if you want logs per session
Dim objFile : Set objFile = goFS.OpenTextFile("c:\scripts\compDisableCheck.log", ForAppending, True)
'objFile[ToAppend] ?

Dim strLine

'Read from file until end of file
'If computer disabled say so / If computer enabled say so
Do Until objFileToRead.AtEndOfStream ' not while not
    strLine = objFileToRead.ReadLine()
    If IsCompDisabled(strLine) Then ' no camparison against boolean literals
       ' timestamp?
       objFile.WriteLine strLine & " has been deleted"
    Else
       ' ? objFile.WriteLine ...
       WScript.Echo strLine & " computer is enabled, no action taken"
    End If
Loop
objFile.Close
objFileToRead.Close

MsgBox "Done"

来源：https://stackoverflow.com/questions/19694180/appending-to-a-file-instead-of-overwritting-the-file-everytime-in-vbscript

标签

file

vbscript

append

overwrite