Writing Sleep function based on time.After

问题

EDIT: My question is different from How to write my own Sleep function using just time.After? It has a different variant of the code that's not working for a separate reason and I needed explanation as to why.

I'm trying to solve the homework problem here: https://www.golang-book.com/books/intro/10 (Write your own Sleep function using time.After).

Here's my attempt so far based on the examples discussed in that chapter:

package main

import (
        "fmt"
        "time"
)

func myOwnSleep(duration int) {
        for {
                select {
                case <-time.After(time.Second * time.Duration(duration)):
                        fmt.Println("slept!")
                default:
                        fmt.Println("Waiting")
                }
        }
}

func main() {
        go myOwnSleep(3)

        var input string
        fmt.Scanln(&input)
}

http://play.golang.org/p/fb3i9KY3DD

My thought process is that the infinite for will keep executing the select statement's default until the time.After function's returned channel talks. Problem with the current code being, the latter does not happen, while the default statement is called infinitely.

What am I doing wrong?

回答1:

In each iteration of your for loop the select statement is executed which involves evaluating the channel operands.

In each iteration time.After() will be called and a new channel will be created!

And if duration is more than 0, this channel is not ready to receive from, so the default case will be executed. This channel will not be tested/checked again, the next iteration creates a new channel which will again not be ready to receive from, so the default case is chosen again - as always.

The solution is really simple though as can be seen in this answer:

func Sleep(sec int) {
    <-time.After(time.Second* time.Duration(sec))
}

Fixing your variant:

If you want to make your variant work, you have to create one channel only (using time.After()), store the returned channel value, and always check this channel. And if the channel "kicks in" (a value is received from it), you must return from your function because more values will not be received from it and so your loop will remain endless!

func myOwnSleep(duration int) {
    ch := time.After(time.Second * time.Duration(duration))
    for {
        select {
        case <-ch:
            fmt.Println("slept!")
            return // MUST RETURN, else endless loop!
        default:
            fmt.Println("Waiting")
        }
    }
}

Note that though until a value is received from the channel, this function will not "rest" and just execute code relentlessly - loading one CPU core. This might even give you trouble if only 1 CPU core is available (runtime.GOMAXPROCS()), other goroutines (including the one that will (or would) send the value on the channel) might get blocked and never executed. A sleep (e.g. time.Sleep(time.Millisecond)) could release the CPU core from doing endless work (and allow other goroutines to run).

来源：https://stackoverflow.com/questions/32937883/writing-sleep-function-based-on-time-after

标签

time

sleep

channel