Segmentation fault (core dumped) Error

问题

My program compiles fines but upon inputting a file I get a "Segmentation fault (core dumped)" error. Am I not handling the ostream correctly?

#include <std_lib_facilities.h>

struct Reading {
    int hour;
    double temperature;
    Reading(int h, double t): hour(h), temperature(t) { }
    bool operator<(const Reading &r) const;
};

bool Reading::operator<(const Reading &r) const
{
// stub version                                                                                         

    if (temperature < r.temperature){

        return true;

}
    else if (r.temperature < temperature)  {

        return false;
    }


}

/*                                                                                                      
 * function declarations                                                                                
 */

ostream& operator<<(ostream& ost, const Reading &r);

vector<Reading> get_temps();

double check_adjust_temp(double temperature, char scale);

double c_to_f(double temperature);

double mean(vector<Reading> temps);

double median(vector<Reading> temps);

void print_results(const vector<Reading>& temps, double mean_temp,
                   double median_temp);

int main()
    try
        {
            vector<Reading> temps = get_temps();
            if (temps.size() == 0) error("no temperatures given!");
            double mean_temp = mean(temps);
            sort(temps.begin(), temps.end());
            double median_temp = median(temps);
            print_results(temps, mean_temp, median_temp);
        }
    catch (exception& e) {
        cerr << "error: " << e.what() << '\n';
        return 1;
    }
    catch (...) {
        cerr << "Oops: unknown exception!\n";
        return 2;
    }

/*                                                                                                      
 * function definitions                                                                                 
 */

ostream& operator<<(ostream& ost, const Reading &r)
{

    return ost << '(' << r.hour
               << ',' << r.temperature <<')';
}

vector<Reading> get_temps()
{
    cout << "Please enter name of input file name: ";
    string name;;
    cin >> name;
    ifstream ist(name.c_str());
    if(!ist) error("can't open input file ", name);

    vector<Reading> temps;
    int hour;
    double temperature;
    while (ist >> hour >> temperature){
        if (hour <0 || 23 <hour) error("hour out of range");
        temps.push_back( Reading(hour,temperature));
    }

}

double check_adjust_temp(double temperature, char scale)
{
    if (scale == 'c' || 'C'){

        return c_to_f(temperature);
    }
    else if (scale == 'f' || 'F')  {

        return temperature;
    }
    else {

        error("Wrong input type");
    }
}

double c_to_f(double temperature)
{
    double c;
    c = ((temperature * (9.0/5)) + 32);
    return (c);
}

double mean(vector<Reading> temps)
{
    double mean_temp;
    double sum = 0;
    for (int i = 0; i< temps.size(); ++i) sum += temps[i].temperature;
    mean_temp = sum/temps.size();
    return (mean_temp);
}

double median(vector<Reading> temps)
{
    double median_temp;
    sort (temps.begin(), temps.end());
    median_temp = temps[temps.size()/2].temperature;
    return (median_temp);
}

void print_results(const vector<Reading>& temps, double mean_temp,
                   double median_temp)
{

    cout << "The sorted temperatures are:\n";
    cout << get_temps;
    cout << "The mean temperature is " << mean_temp << ".\n";
    cout << "The median temperature is " << median_temp << ".\n";
}

回答1:

scale == 'c' || 'C'

does not do what you think it does. It parses like this:

( scale == 'c' ) || 'C'

and 'C' is always true. If you had compiler warnings enabled, you should have noticed this.

(No, this is not your immediate problem; it's up at the end of get_temps. But with warnings enabled, you would have seen that too.)

回答2:

Attach a debugger and step through your code. It's possible you are dividing by 0 or running past the end of an array. At the very least we need more info before we can help.

回答3:

Are you compiling on a linux machine? If so, Valgrind is a great tool for diagnosing segmentation fault errors.

回答4:

What does error do? If it's not throwing an exception, then code that calls it will keep going with bogus data.

cin >> name; only reads a "word" from the standard input, not a whole line. So if there are spaces in the file name, your program won't get the correct file name.

来源：https://stackoverflow.com/questions/4363133/segmentation-fault-core-dumped-error