using zipArchive addFile() will not add image to zip

Question

I've been at this for a while. This actually worked one time, then never again. it simply does not create the zip file. The file does exist.

$zip = new ZipArchive();
$filename = "./test" . time() .".zip";

if ($zip->open($filename, ZIPARCHIVE::CREATE)!==TRUE) {      
    exit("cannot open <$filename>\n");
}

$thisdir = "$_SERVER[DOCUMENT_ROOT]/zip";
$zip->addFile($thisdir . "/trash-icon.png", "/gabage.png");
echo "numfiles: " . $zip->numFiles . "\n";
echo "status:" . $zip->status . "\n";
$zip->close();

If I add something like

$zip->addFromString("testfilephp.txt", "#1 This is a test string added as testfilephp.txt.\n"); 

it creates the zip with the txt file in it.. but a no go for anytype of existing file.

Answer 1

The ZipArchive::addFile() method accepts the path to the file as its first parameter, but not all paths are created equal. addFile() method silently rejects the file and you never know what went wrong. As can be derived from the question, an alternative approach would be:

// $zip->addFile($file);
$content = file_get_contents($file);
$zip->addFromString(pathinfo ( $file, PATHINFO_BASENAME), $content);

In addition to getting the code working, file_get_contents() also generates decent error messages.

Answer 2

The ZipArchive::addFile() method accepts the path to the file as its first parameter.

Here, you are using :

$zip->addFile("/trash-icon.png", "/gabage.png");

Which means you are trying to add the /trash-icon.png file to your archive.

Are you sure this file exists ?

Note there is a / at the beginning of that file's path, which indicates it's an absolute path.
Maybe that / should be removed, to use a relative path ?

Answer 3

I had similar kind of issue and it was related with the file that I was going to add to the zip archive.

Before adding file to zip archive, it's always better to check if the file exists.

$thisdir = "$_SERVER[DOCUMENT_ROOT]/zip";
if (file_exists($thisdir . "/trash-icon.png")) {
    $zip->addFile($thisdir . "/trash-icon.png", "/gabage.png");
}

Answer 4

See the answer to this question - it also works for images, and uses addFile instead of addFromString, which as far as I know is lighter in memory usage.