I have a model that defines mutually recursive tables:
Answer
questionId QuestionId
text
Question
text
correct AnswerId
What do I need to do to actually insert a question? I need to know what the correct answer is first. But to insert an answer, I need to know what question it answers.
I'm running Postgres, if it matters.
The DDL is:
CREATE TABLE answer (
id integer NOT NULL, -- answer id
text character varying NOT NULL, -- answer text
question_id bigint NOT NULL -- question id
);
CREATE TABLE question (
id integer NOT NULL, -- question id
question character varying NOT NULL, -- question text
correct bigint NOT NULL, -- correct answer
solution character varying NOT NULL -- solution text
);
ALTER TABLE ONLY answer ALTER COLUMN id SET DEFAULT nextval('answer_id_seq'::regclass);
ALTER TABLE ONLY answer
ADD CONSTRAINT answer_question_id_fkey FOREIGN KEY (question_id) REFERENCES question(id);
ALTER TABLE ONLY question ALTER COLUMN id SET DEFAULT nextval('question_id_seq'::regclass);
ALTER TABLE ONLY question
ADD CONSTRAINT question_correct_fkey FOREIGN KEY (correct) REFERENCES answer(id);
If you enter question and answer in a single statement with a data-modifying CTE, you do not even need a DEFERRABLE
FK constraints. Not to speak of actually making (or SET
ting) them DEFERRED
- which would be a lot more expensive.
Data model
First I cleaned up your data model:
CREATE TABLE question (
question_id serial PRIMARY KEY
, correct_answer_id int NOT NULL
, question text NOT NULL
, solution text NOT NULL
);
CREATE TABLE answer (
answer_id serial PRIMARY KEY
, question_id int NOT NULL REFERENCES question
, answer text NOT NULL
);
ALTER TABLE question ADD CONSTRAINT question_correct_answer_id_fkey
FOREIGN KEY (correct_answer_id) REFERENCES answer(answer_id);
- Don't use the non-descriptive "id" as column name.
- Don't use basic type names like
text
as column name. - Put the integer columns first for space efficiency:
bigint
was uncalled for,integer
should suffice.- Simplify your schema definition with
serial
columns. - Define primary keys. PK columns are
NOT NULL
automatically.
Solution
I delegated primary key generation to sequences (serial
columns) like it should be in most data models. We can get the auto-generated ID with the RETURNING
clause of the INSERT
statement. But in this special case we need both IDs for each INSERT
, so I fetch one of them with nextval()
to get the thing started.
WITH q AS (
INSERT INTO question (correct_answer_id, question, solution)
VALUES (nextval('answer_answer_id_seq'), 'How?', 'DEFERRABLE FK & wCTE')
RETURNING correct_answer_id, question_id
)
INSERT INTO answer (answer_id, question_id, answer)
SELECT correct_answer_id, question_id, 'Use DEFERRABLE FK & data-modifying CTE'
FROM q;
I know the name of the sequence ('answer_answer_id_seq'
) because I looked it up. It's the default name. If you don't know it use the safe form @IMSoP provided in the comment below:
nextval(pg_get_serial_sequence('answer', 'answer_id'))
DEFERRABLE
or DEFERRED
constraints?
Per documentation on SET CONSTRAINTS
IMMEDIATE
constraints are checked at the end of each statement.
My solution is a single statement. That's why it works where two separate statements would fail - wrapped in a single transaction or not. And you'd need SET CONSTRAINTS ... DEFERRED;
like IMSoP first commented and @Jaaz implemented in his answer.
However, note the disclaimer some paragraphs down:
Uniqueness and exclusion constraints that have not been declared
DEFERRABLE
are also checked immediately.
So UNIQUE
and EXCLUDE
need to be DEFERRALBE
to make wCTEs work for them. This includes PRIMARY KEY
constraints. The documentation on CREATE TABLE
has more details:
Non-deferred Uniqueness Constraints
When a
UNIQUE
orPRIMARY KEY
constraint is not deferrable, PostgreSQL checks for uniqueness immediately whenever a row is inserted or modified. The SQL standard says that uniqueness should be enforced only at the end of the statement; this makes a difference when, for example, a single command updates multiple key values. To obtain standard-compliant behavior, declare the constraint asDEFERRABLE
but not deferred (i.e.,INITIALLY IMMEDIATE
). Be aware that this can be significantly slower than immediate uniqueness checking.
We discussed this in great detail under this related question:
I would insert into question, with a null correct AnswerId. Then I would insert into Answer, and finally I would update Question and set the correct answerId.
I went looking around after seeing the DDL. Consider a function for your call to insert a question with correct answer, and one to add (false) answers to a given question. The structure of the first function allows the application to pick up the anonymous returned record for the questionID, and use it for subsequent calls to the second function, to add false answers.
CREATE FUNCTION newQuestion (questionText varchar, questionSolutionText varchar, answerText varchar, OUT questionID integer) AS $$
BEGIN
START TRANSACTION;
SET CONSTRAINTS question_correct_fkey DEFERRED;
questionID := nextval('question_id_seq');
answerID := nextval('answer_id_seq');
INSERT INTO question (id, question, correct, solution) values (questionID, questionText, answerID, questionSolutionText);
INSERT INTO answer (id, text, question_id) values (answerID, answerText, questionID);
SET CONSTRAINTS question_correct_fkey IMMEDIATE;
COMMIT TRANSACTION;
END;
$$
CREATE FUNCTION addFalseAnswer (questionID integer, answerText varchar) AS $$
BEGIN
INSERT INTO answer (text, question_id) VALUES (answerText, questionID);
END;
$$
I've not written SQL for PostGreSQL in a long while, so I hope all is in order here. please let me know if there are any issues.
来源:https://stackoverflow.com/questions/24813000/how-to-deal-with-mutually-recursive-inserts