Visual Studio Recommending to Simplify Using Command

问题

I've noticed since updating Visual Studio that it is now recommending to simplify my MySQL using statements.

It wants to change this:

            using (MySqlCommand command = new MySqlCommand(sql_string, connection))
            {
                command.Parameters.AddWithValue("@id", id);

                MySqlDataReader reader = command.ExecuteReader();

                if (reader.HasRows)
                {
                    reader.Read();

                    business = new Business()
                    {
                        Id = int.Parse(reader["id"].ToString()),
                        Name = reader["name"].ToString(),
                    };

                    reader.Dispose();
                }
            }

Into this:

            using MySqlCommand command = new MySqlCommand(sql_string, connection);
            command.Parameters.AddWithValue("@id", id);

            MySqlDataReader reader = command.ExecuteReader();

            if (reader.HasRows)
            {
                reader.Read();

                business = new Business()
                {
                    Id = int.Parse(reader["id"].ToString()),
                    Name = reader["name"].ToString(),
                };

                reader.Dispose();
            }

My question is, previously the code would be wrapped in brackets like so:

            using (MySqlCommand command = new MySqlCommand(sql_string, connection))
            {

            }

Is the recommended suggestion by IntelliSense valid and won't cause any leaks?

回答1:

This is called a Using Declaration.

A using declaration is a variable declaration preceded by the using keyword. It tells the compiler that the variable being declared should be disposed at the end of the enclosing scope.

As long as you need the using variable in the same scope suggested by the compiler, it should not be a problem.

Reference: https://docs.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-8#using-declarations

来源：https://stackoverflow.com/questions/58609253/visual-studio-recommending-to-simplify-using-command

标签

visual-studio

using

c#-8.0