Followup: Etiquette of GitHub Contributing, Pull Requests vs New Issue

╄→尐↘猪︶ㄣ 提交于 2020-01-05 08:10:33

问题


as a followup to Etiquette of GitHub Contributing, Pull Requests vs New Issue:

What is the 'etiquette' way of submitting a pull request to an all-ready pulled bit of code?

Consider:

Author A - owns the repo for TowerApp.
Author B - forks TowerApp, creates a new feature - ElevatorModule, 
             then submits a pull request.    
Author A - likes the ElevatorModule pull request so he/she merges it
Author C - finds Author A's TowerApp and wants to update ElevatorMusic in 
             ElevatorModule that was recently merged from Author B's 
             pull request.

What does Author C do?

  • Fork Author B's repo and 'pull request' the update to Author B

or

  • Fork Author A's repo and 'pull request' the update the Author A

回答1:


As B eventually submitted a pull request to A, TowerApp looks like the main upstream repository.

I'd go with forking A's repo and notifying B on the Pull Request in order to keep him in the loop.

As in, for instance:

"This adds ElevatorMusic feature to @B's awesome work with the ElevatorModule"

This will allow B to chime in and review/comment on the pull request as well.



来源:https://stackoverflow.com/questions/16113032/followup-etiquette-of-github-contributing-pull-requests-vs-new-issue

易学教程内所有资源均来自网络或用户发布的内容,如有违反法律规定的内容欢迎反馈
该文章没有解决你所遇到的问题?点击提问,说说你的问题,让更多的人一起探讨吧!