Phabricator Is there a way to change default “Accept” policy in “Differential” to require “all” reviews to accept, rather than “some”?

ぃ、小莉子 提交于 2019-12-25 03:56:18

问题


As per 'Differential' documentation: https://secure.phabricator.com/book/phabricator/article/differential/

Once everything is satisfied, some reviewer accepts the change and the author pushes it to the upstream.

This means any reviewer can mark the overall review state as 'Accepted', even though some reviewers may have open questions.

Is there a way to change it so review is marked "Accept"ed when all reviewers have accepted it?


回答1:


even though some reviewers may have open questions

This is a bit problematic. Fundamentally if you have an engineer ignoring code feedback on a review and pushing the code anyways, that engineer should be talked to separately. The point of flexible code reviews in Phabricator is most people can be trusted the majority of time, and through that the product enables greater workflow speed and keeps things unblocked (and engineers working).

If you don't trust your engineers, tools like Herald (to add blocking reviewers) and Owners (code ownership packages) still achieve most of what you'd likely want.

https://secure.phabricator.com/T731 is the task tracking "all must accept" type rules in the upstream.



来源:https://stackoverflow.com/questions/33613611/phabricator-is-there-a-way-to-change-default-accept-policy-in-differential-t

标签
易学教程内所有资源均来自网络或用户发布的内容,如有违反法律规定的内容欢迎反馈
该文章没有解决你所遇到的问题?点击提问,说说你的问题,让更多的人一起探讨吧!