Critical Sections and return values in C++

北战南征 提交于 2019-12-22 04:42:15

问题


In attempting to create a thread-safe container class from scratch, I've run into the problem of returning values from access methods. For example in Windows:

myNode getSomeData( )
{
  EnterCriticalSection(& myCritSec);
  myNode retobj;
  // fill retobj with data from structure
  LeaveCriticalSection(& myCritSec);
  return retobj;
}

Now I suppose that this type of method is not at all thread-safe because after the code releases the critical section another thread is able to come along and immediately overwrite retobj before the first thread returns. So what is an elegant way to return retobj to the caller in a thread-safe manner?


回答1:


No, it's thread-safe because each thread has it's own stack, and that's where retobj is.

However, it's certainly not exception-safe. Wrap the critical section in a RAII-style object would help that. Something like...

class CriticalLock : boost::noncopyable {
  CriticalSection &section;

public:
  CriticalLock(CriticalSection &cs) : section(cs)
  {
    EnterCriticalSection(section);
  }

  ~CriticalLock()
  {
    LeaveCriticalSection(section);
  }
};

Usage:

myNode getSomeData( )
{
  CriticalLock  lock(myCritSec);  // automatically released.
  ...
} 



回答2:


This is C++, and retobj has automatic storage type, so it's stored on the stack.

Every thread has its own stack, so another thread cannot clobber the value of retobj before it is returned.



来源:https://stackoverflow.com/questions/11653062/critical-sections-and-return-values-in-c

易学教程内所有资源均来自网络或用户发布的内容,如有违反法律规定的内容欢迎反馈
该文章没有解决你所遇到的问题?点击提问,说说你的问题,让更多的人一起探讨吧!