问题
Here's the scenario:
Silverlight 4.0, DataGrid, PagedCollectionView itemssource.
The objective is to apply a Filter to the PCV. The filter needs to be a Predicate<object>(Method)
- where Method implements some logic against the object and returns true/false for inclusion.
What I have is a need to optionally include 3 different criteria in the filter logic and explicit code quickly gets ugly. We don't want that, do we?
So I see that there is a way to build an expression tree using PredicateBuilder and pass that into Linq.Where, a la:
IQueryable<Product> SearchProducts (params string[] keywords)
{
var predicate = PredicateBuilder.False<Product>();
foreach (string keyword in keywords)
{
string temp = keyword;
predicate = predicate.Or (p => p.Description.Contains (temp));
}
return dataContext.Products.Where (predicate);
}
[this is not what I'm trying to do by the way]
With 3 optional criteria, I want to write something like:
Ratings.Filter = BuildFilterPredicate(); // Ratings = the PagedCollectionView
private Predicate<object> BuildFilterPredicate()
{
bool FilterOnOrder = !String.IsNullOrEmpty(sOrderNumberFilter);
var predicate = PredicateBuilder.False<object>();
if (ViewMineOnly)
{
predicate = predicate.And(Rating r => sUserNameFilter == r.Assigned_To);
}
if (ViewStarOnly)
{
predicate = predicate.And(Rating r => r.Star.HasValue && r.Star.Value > 0);
}
if (FilterOnOrder)
{
predicate = predicate.And(Rating r => r.ShipmentInvoice.StartsWith(sOrderNumberFilter));
}
return predicate;
}
Of course this won't compile because PredicateBuilder creates an Expression<Func<T, bool>>
not an actual predicate method. But I see that there are ways to convert an expression tree into a method so it seemed to me there ought to be a way to accomplish what I'm after without resorting to a bunch of nested if/then/else statements.
So the question is - is there a way to build a predicate method dynamically?
TIA
回答1:
to do this for a PagedCollectionView, you need to have a Predicate. So it looks like:
private Predicate<object> ConvertExpressionToPredicate(Expression<Func<object, bool>> exp)
{
Func<object, bool> func = exp.Compile();
Predicate<object> predicate = new Predicate<object>(func);
//Predicate<object> predicate = t => func(t); // also works
//Predicate<object> predicate = func.Invoke; // also works
return predicate;
}
and build the expression:
private Expression<Func<object, bool>> BuildFilterExpression()
{
...snip...
var predicate = PredicateBuilder.True<object>();
if (ViewMineOnly)
{
predicate = predicate.And(r => ((Rating)r).Assigned_To.Trim().ToUpper() == sUserNameFilter || ((Rating)r).Assigned_To.Trim().ToUpper() == "UNCLAIMED");
}
if (ViewStarOnly)
{
predicate = predicate.And(r => ((Rating)r).Star.HasValue && ((Rating)r).Star.Value > 0);
}
if (FilterOnOrder)
{
predicate = predicate.And(r => ((Rating)r).ShipmentInvoice.Trim().ToUpper().StartsWith(sOrderNumberFilter));
}
if (ViewDueOnly)
{
predicate = predicate.And(r => ((Rating)r).SettlementDueDate <= ThisThursday);
}
return predicate;
}
and then set the filter:
Ratings.Filter = ConvertExpressionToPredicate(BuildFilterExpression());
回答2:
I faced the same problem. I had 3 criteria. What I did is the following :
- One method to validate each criteria
- One method to validate the object
The code looked quite clean and it was easy to maintain.
Ratings.Filter = new predicate<objects>(validateObject);
private bool validateObject(object o)
{
return validateFirstCriteria(o) &&
validateSecondCriteria(o) &&
validateThirdCriteria(o);
}
private bool validateFirstObject(object o)
{
if (ViewMineOnly)
{
Rating r = o as Rating;
if (o != null)
{
return (r.Star.HasValue && r.Star.Value > 0);
}
}
return false;
}
private bool validateSecondObject(object o)
{
if (ViewStarOnly)
{
Rating r = o as Rating;
if (o != null)
{
return sUserNameFilter == r.Assigned_To;
}
}
return false;
}
private bool validateThirdObject(object o)
{
if (FilterOnOrder)
{
Rating r = o as Rating;
if (o != null)
{
return r.ShipmentInvoice.StartsWith(sOrderNumberFilter);
}
}
return false;
}
EDIT
If you want to stuck to Expression trees. You could take a look here : http://msdn.microsoft.com/en-us/library/bb882536.aspx
You can convert the expression tree to a lambda expression and then compile the lambda expression. After then you can use it as a method. Exemple :
// The expression tree to execute.
BinaryExpression be = Expression.Power(Expression.Constant(2D), Expression.Constant(3D));
// Create a lambda expression.
Expression<Func<double>> le = Expression.Lambda<Func<double>>(be);
// Compile the lambda expression.
Func<double> compiledExpression = le.Compile();
// Execute the lambda expression.
double result = compiledExpression();
// Display the result.
Console.WriteLine(result);
// This code produces the following output:
// 8
回答3:
Thanks to Benjamin's hints and this post -> How to convert Func<T, bool> to Predicate<T>?
I figured it out.
The essence is:
private static Predicate<T> ConvertExpressionToPredicate(Expression<Func<T, bool>> exp)
{
Func<T, bool> func = exp.Compile();
Predicate<T> predicate = new Predicate<T>(func);
//Predicate<T> predicate = t => func(t); // also works
//Predicate<T> predicate = func.Invoke; // also works
return predicate;
}
This will compile the expression tree to a single function and return a predicate to call the function.
In use, it looks like:
private static bool ViewStarOnly;
private static bool LongNameOnly;
static void Main(string[] args)
{
List<Dabble> data = GetSomeStuff();
ViewStarOnly = true;
LongNameOnly = true;
Expression<Func<Dabble, bool>> exp = BuildFilterExpression();
List<Dabble> filtered = data.FindAll(ConvertExpressionToPredicate(exp));
PrintSomeStuff(filtered);
}
private static Predicate<Dabble> ConvertExpressionToPredicate(Expression<Func<Dabble, bool>> exp)
{
Func<Dabble, bool> func = exp.Compile();
Predicate<Dabble> predicate = new Predicate<Dabble>(func);
//Predicate<Dabble> predicate = t => func(t); // also works
//Predicate<Dabble> predicate = func.Invoke; // also works
return predicate;
}
private static Expression<Func<Dabble, bool>> BuildFilterExpression()
{
var predicate = PredicateBuilder.True<Dabble>();
if (ViewStarOnly)
{
predicate = predicate.And(r => r.Star.HasValue && r.Star.Value > 0);
}
if (LongNameOnly)
{
predicate = predicate.And(r => r.Name.Length > 3);
}
return predicate;
}
Thanks!
来源:https://stackoverflow.com/questions/3755617/how-do-i-dynamically-construct-a-predicate-method-from-an-expression-tree