问题
I've had a subclass of DialogFragment (android.support.v4.app.DialogFragment) in my app that worked fine for a long time. The dialog itself was constructed in onCreateDialog() callback.
Now, however, I want to transition to a new dialogs layout and decided to construct a completely customized dialog. To my best knowledge, this requires removing override of onCreateDialog() and inflating a View hierarchy in onCreateView() callback. I did so.
The resulting behavior is very strange - when the dialog needs to be shown, the screen dims, but the layout of the dialog is not shown (the behavior of "back" button is also consistent with dialog's functionality):
I tried to revert back to the old implementation (which uses onCreateDialog() callback) - it still works.
My question is: what am I doing wrong?
Dialog's code:
/**
* A dialog that can show title and message and has two buttons. User's actions performed
* in this dialog will be posted to {@link EventBus} as {@link PromptDialogDismissedEvent}.
*/
public class PromptDialog extends BaseDialog {
/* package */ static final String ARG_TITLE = "ARG_TITLE";
/* package */ static final String ARG_MESSAGE = "ARG_MESSAGE";
/* package */ static final String ARG_POSITIVE_BUTTON_CAPTION = "ARG_POSITIVE_BUTTON_CAPTION";
/* package */ static final String ARG_NEGATIVE_BUTTON_CAPTION = "ARG_NEGATIVE_BUTTON_CAPTION";
@Inject EventBus mEventBus;
private TextView mTxtTitle;
private TextView mTxtMessage;
private Button mBtnPositive;
private Button mBtnNegative;
@Override
public void onAttach(Activity activity) {
super.onAttach(activity);
getControllerComponent().inject(this);
}
// THIS CODE MAKES THE SCREEN DIM, BUT THE ACTUAL LAYOUT IS NOT SHOWN
@Nullable
@Override
public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
View rootView = inflater.inflate(R.layout.dialog_info_prompt, container, false);
initSubViews(rootView);
populateSubViews();
return rootView;
}
private void initSubViews(View rootView) {
mTxtTitle = (TextView) rootView.findViewById(R.id.txt_dialog_title);
mTxtMessage = (TextView) rootView.findViewById(R.id.txt_dialog_message);
mBtnPositive = (Button) rootView.findViewById(R.id.btn_dialog_positive);
mBtnNegative = (Button) rootView.findViewById(R.id.btn_dialog_negative);
mBtnPositive.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
mEventBus.post(new PromptDialogDismissedEvent(getDialogTag(), PromptDialogDismissedEvent.BUTTON_POSITIVE));
}
});
mBtnNegative.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
mEventBus.post(new PromptDialogDismissedEvent(getDialogTag(), PromptDialogDismissedEvent.BUTTON_NEGATIVE));
}
});
}
private void populateSubViews() {
String title = getArguments().getString(ARG_TITLE);
String message = getArguments().getString(ARG_MESSAGE);
String positiveButtonCaption = getArguments().getString(ARG_POSITIVE_BUTTON_CAPTION);
String negativeButtonCaption = getArguments().getString(ARG_NEGATIVE_BUTTON_CAPTION);
mTxtTitle.setText(TextUtils.isEmpty(title) ? "" : title);
mTxtMessage.setText(TextUtils.isEmpty(message) ? "" : message);
mBtnPositive.setText(positiveButtonCaption);
mBtnNegative.setText(negativeButtonCaption);
}
// THE BELOW CODE WORKS FINE (the dialog is shown and responsive)
// @Override
// public @NonNull Dialog onCreateDialog(Bundle savedInstanceState) {
// String title = getArguments().getString(ARG_TITLE);
// String message = getArguments().getString(ARG_MESSAGE);
// String positiveButtonCaption = getArguments().getString(ARG_POSITIVE_BUTTON_CAPTION);
// String negativeButtonCaption = getArguments().getString(ARG_NEGATIVE_BUTTON_CAPTION);
//
// Dialog dialog = new AlertDialog.Builder(getActivity())
// .setTitle(TextUtils.isEmpty(title) ? "" : title)
// .setMessage(TextUtils.isEmpty(message) ? "" : message)
// .setPositiveButton(TextUtils.isEmpty(positiveButtonCaption) ? "" : positiveButtonCaption,
// new DialogInterface.OnClickListener() {
// @Override
// public void onClick(DialogInterface dialog, int which) {
// mEventBus.post(new PromptDialogDismissedEvent(getDialogTag(), PromptDialogDismissedEvent.BUTTON_POSITIVE));
// }
// })
// .setNegativeButton(TextUtils.isEmpty(negativeButtonCaption) ? "" : negativeButtonCaption,
// new DialogInterface.OnClickListener() {
// @Override
// public void onClick(DialogInterface dialog, int which) {
// mEventBus.post(new PromptDialogDismissedEvent(getDialogTag(), PromptDialogDismissedEvent.BUTTON_NEGATIVE));
// }
// })
// .create();
//
// return dialog;
// }
}
Custom dialog's layout:
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:orientation="vertical"
android:layout_width="match_parent"
android:layout_height="match_parent">
<TextView
android:id="@+id/txt_dialog_title"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="15dp"
android:layout_gravity="center_horizontal"
style="@style/AppTheme.TextView.DialogTitle"
tools:text="Dialog title"/>
<View
android:layout_width="match_parent"
android:layout_height="1dp"
android:layout_marginTop="10dp"
android:background="@color/gray"/>
<RelativeLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:padding="@dimen/fragment_default_padding">
<TextView
android:id="@+id/txt_dialog_message"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="10dp"
style="@style/AppTheme.TextView.DialogMessage"
tools:text="Dialog message very very very very very very very very very very very very long"/>
<Button
android:id="@+id/btn_dialog_positive"
android:layout_width="wrap_content"
android:layout_height="@dimen/button_height"
android:layout_marginTop="15dp"
android:layout_below="@id/txt_dialog_message"
android:layout_alignParentEnd="true"
android:layout_alignParentRight="true"
style="@style/AppTheme.GreenButton"
tools:text="Positive"/>
<Button
android:id="@+id/btn_dialog_negative"
android:layout_width="wrap_content"
android:layout_height="@dimen/button_height"
android:layout_marginTop="15dp"
android:layout_below="@id/txt_dialog_message"
android:layout_toStartOf="@+id/btn_dialog_positive"
android:layout_toLeftOf="@id/btn_dialog_positive"
android:layout_marginEnd="15dp"
android:layout_marginRight="15dp"
style="@style/AppTheme.GrayButton"
tools:text="Negative"/>
</RelativeLayout>
</LinearLayout>
回答1:
I ended up with this workaround, but I'd still want to understand WTF:
// This is a workaround for the strange behavior of onCreateView (which doesn't show dialog's layout)
@NonNull
@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
AlertDialog.Builder dialogBuilder = new AlertDialog.Builder(getContext());
LayoutInflater inflater = LayoutInflater.from(getContext());
View dialogView = inflater.inflate(R.layout.dialog_info_prompt, null);
dialogBuilder.setView(dialogView);
initSubViews(dialogView);
populateSubViews();
setCancelable(false);
return dialogBuilder.create();
}
private void initSubViews(View rootView) {
mTxtTitle = (TextView) rootView.findViewById(R.id.txt_dialog_title);
mTxtMessage = (TextView) rootView.findViewById(R.id.txt_dialog_message);
mBtnPositive = (Button) rootView.findViewById(R.id.btn_dialog_positive);
mBtnNegative = (Button) rootView.findViewById(R.id.btn_dialog_negative);
mBtnPositive.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
dismiss();
mEventBus.post(new PromptDialogDismissedEvent(getDialogTag(), PromptDialogDismissedEvent.BUTTON_POSITIVE));
}
});
mBtnNegative.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
dismiss();
mEventBus.post(new PromptDialogDismissedEvent(getDialogTag(), PromptDialogDismissedEvent.BUTTON_NEGATIVE));
}
});
}
private void populateSubViews() {
String title = getArguments().getString(ARG_TITLE);
String message = getArguments().getString(ARG_MESSAGE);
String positiveButtonCaption = getArguments().getString(ARG_POSITIVE_BUTTON_CAPTION);
String negativeButtonCaption = getArguments().getString(ARG_NEGATIVE_BUTTON_CAPTION);
mTxtTitle.setText(TextUtils.isEmpty(title) ? "" : title);
mTxtMessage.setText(TextUtils.isEmpty(message) ? "" : message);
mBtnPositive.setText(positiveButtonCaption);
mBtnNegative.setText(negativeButtonCaption);
}
回答2:
Maybe a bit late, but I stumbled across this post because I had the same issue in my application. I still don't know why it happens, but I followed this Medium article on how to setup a DialogFragment and it seems that changing the dialog's window size on onStart might fix this issue.
styles.xml
<style name="FullScreenDialogStyle" parent="Theme.AppCompat.Dialog">
<item name="android:windowNoTitle">true</item>
<item name="colorPrimaryDark">@color/primary_dark</item>
<item name="colorPrimary">@color/primary</item>
<!-- Set this to true if you want Full Screen without status bar -->
<item name="android:windowFullscreen">false</item>
<item name="android:windowIsFloating">true</item>
<!-- This is important! Don't forget to set window background -->
<item name="android:windowBackground">@color/background_dialog</item>
</style>
DialogFragment
@Override
public void onCreate(@Nullable Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setStyle(DialogFragment.STYLE_NORMAL, R.style.FullScreenDialogStyle);
}
@Override
public void onStart() {
super.onStart();
Dialog dialog = getDialog();
if (dialog == null || dialog.getWindow() == null)
return;
int width = 776; //Width of your dialog
int height = 512; //Height of your dialog
dialog.getWindow().setLayout(width, height);
}
来源：https://stackoverflow.com/questions/41730660/android-support-dialogfragment-with-custom-layout-not-shown