Saving datetime in UTC isn't accurate sometimes

后端 未结 3 1583
隐瞒了意图╮
隐瞒了意图╮ 2021-02-01 21:34

In general, best practice when dealing with dates is to store them in UTC and convert back to whatever the user expects within the application layer.

That doesn\'t neces

相关标签:
3条回答
  • 2021-02-01 22:06

    I vote the simplest route and that's saving to UTC. Create a column for country of origin, set up a google alert for "daylight savings time", and if Chile decides to stop using daylight savings or alter it in some crazy way, you can adapt by querying your database for Chilean users and adjusting their dates accordingly with a script. Then, you can use Time.parse with the date, time and timezone. To illustrate, here are the results the day before daylight savings and after daylight savings on 3/13/2016:

    Time.parse("2016-03-12 12:00:00 Pacific Time (US & Canada)").utc
    => 2016-03-12 20:00:00 UTC
    Time.parse("2016-03-14 12:00:00 Pacific Time (US & Canada)").utc
    => 2016-03-14 19:00:00 UTC
    

    This will get you a list of the accepted time zone names:

    timezones = ActiveSupport::TimeZone.zones_map.values.collect{|tz| tz.name}
    
    0 讨论(0)
  • 2021-02-01 22:17

    I propose that you still use the first option but with a little hack: in essence, you can switch off the time zone conversion for the desired attribute and use a custom setter to overcome the conversion during attribute writes.

    The trick saves the time as a fake UTC time. Although technically it has an UTC zone (as all the times are saved in db in UTC) but by definition it shall be interpreted as local time, regardless of the current time zone.

    class Model < ActiveRecord::Base
      self.skip_time_zone_conversion_for_attributes = [:start_time]
    
      def start_time=(time)
        write_attribute(:start_time, time ? time + time.utc_offset : nil)
      end
    end
    

    Let's test this in rails console:

    $ rails c
    >> future_time = Time.local(2020,03,30,11,55,00)
    => 2020-03-30 11:55:00 +0200
    
    >> Model.create(start_time: future_time)
    D, [2016-03-15T00:01:09.112887 #28379] DEBUG -- :    (0.1ms)  BEGIN
    D, [2016-03-15T00:01:09.114785 #28379] DEBUG -- :   SQL (1.4ms)  INSERT INTO `models` (`start_time`) VALUES ('2020-03-30 11:55:00')
    D, [2016-03-15T00:01:09.117749 #28379] DEBUG -- :    (2.7ms)  COMMIT
    => #<Model id: 6, start_time: "2020-03-30 13:55:00">
    

    Note that Rails saved the time as a 11:55, in a "fake" UTC zone.

    Also note that the time in the object returned from create is wrong because the zone is converted from the "UTC" in this case. You would have to count with that and reload the object every time after setting the start_time attribute, so that the zone conversion skipping can take place:

    >> m = Model.create(start_time: future_time).reload
    D, [2016-03-15T00:08:54.129926 #28589] DEBUG -- :    (0.2ms)  BEGIN
    D, [2016-03-15T00:08:54.131189 #28589] DEBUG -- :   SQL (0.7ms)  INSERT INTO `models` (`start_time`) VALUES ('2020-03-30 11:55:00')
    D, [2016-03-15T00:08:54.134002 #28589] DEBUG -- :    (2.5ms)  COMMIT
    D, [2016-03-15T00:08:54.141720 #28589] DEBUG -- :   Model Load (0.3ms)  SELECT  `models`.* FROM `models` WHERE `models`.`id` = 10 LIMIT 1
    => #<Model id: 10, start_time: "2020-03-30 11:55:00">
    
    >> m.start_time
    => 2020-03-30 11:55:00 UTC
    

    After loading the object, the start_time attribute is correct and can be manually interpreted as local time regardless of the actual time zone.

    I really don't get it why Rails behaves the way it does regarding the skip_time_zone_conversion_for_attributes configuration option...

    Update: adding a reader

    We can also add a reader so that we automatically interpret the saved "fake" UTC time in local time, without shifting the time due to timezone change:

    class Model < ActiveRecord::Base
      # interprets time stored in UTC as local time without shifting time
      # due to time zone change
      def start_time
        t = read_attribute(:start_time)
        t ? Time.local(t.year, t.month, t.day, t.hour, t.min, t.sec) : nil
      end
    end
    

    Test in rails console:

    >> m = Model.create(start_time: future_time).reload
    D, [2016-03-15T08:10:54.889871 #28589] DEBUG -- :    (0.1ms)  BEGIN
    D, [2016-03-15T08:10:54.890848 #28589] DEBUG -- :   SQL (0.4ms)  INSERT INTO `models` (`start_time`) VALUES ('2020-03-30 11:55:00')
    D, [2016-03-15T08:10:54.894413 #28589] DEBUG -- :    (3.1ms)  COMMIT
    D, [2016-03-15T08:10:54.895531 #28589] DEBUG -- :   Model Load (0.3ms)  SELECT  `models`.* FROM `models` WHERE `models`.`id` = 12 LIMIT 1
    => #<Model id: 12, start_time: "2020-03-30 11:55:00">
    
    >> m.start_time
    => 2020-03-30 11:55:00 +0200
    

    I.e. the start_time is correctly interpreted in local time, even though it was stored as the same hour and minute, but in UTC.

    0 讨论(0)
  • 2021-02-01 22:25

    This may sound a bit out there, but I have dealt with similar issues with a recent application I was tasked with - but on the opposite side - when I run an ETL to load data for the application, dates from the source are stored in EST. Rails believes that it is UTC when serving the data, so for that, I converted the dates back to UTC using P/SQL. I did not want these dates to be different than the other date fields within the app.

    Option A In this case, could you capture the user timezone at creation, and send that back as a hidden field in the form? I am still learning RoR, so am not sure on the "proper" way to do this, but right now I would do something like this:

    Example (I tested this, and it will submit the offset (minutes) in a hidden field):

    <div class="field">
      <%= f.hidden_field :offset %>
    </div>
    
    <script>
      utcDiff = new Date().getTimezoneOffset();
      dst_field = document.getElementById('timepage_offset');
      dst_field.value = utcDiff;
    </script>
    

    If you then send utcDiff along with the user selected date, you could calculate the UTC date before storing. I suppose you could add that to the model as well if that data is necessary to know at a later date.

    I think that no matter how this is done, there will always be slight area for confusion, unless the user is capable of providing the proper information, which leads me to...

    Option B: You could, instead of a hidden field, provide a select list (and to be friendly, default it to the users' local offset), to allow them to provide the zone for which their date is specified in.

    Update - TimeZone select I've done some research, and it looks like there is already a form helper for a time zone select box.

    0 讨论(0)
提交回复
热议问题