Difference between setattr and object manipulation in python/django

Question

I have the following model:

class Ticket(models.Model):
    title = models.CharField()
    merged_to = models.ForeignKey(\"self\", related_name=\'merger_ticket\'         


        

Answer 1

This is more of a Python question.

Python is very dynamic language. You can code things (classes) ahead of time, or Python allows you to create classes completely dynamically at run-time. Consider the following example of a simple vector class. You can create/code the class ahead of time like:

class MyVector(object):
    x = 0
    y = 0

or you can create the class dynamically by doing:

fields = {'x':0, 'y':0}
MyVector = type('MyVector', (object,), fields)

The main difference between the methods is that for one you know the class attributes ahead of time, whereas for the second method as you can imagine, you can programmatically create the fields dictionary, therefore you can create completely dynamically class(es).

So when you know the attributes of the class ahead of time, you can set class attributes using the object notation:

instance.attribute = value

Keep in mind that that is equivalent to:

instance.__setattr__("attribute", value)

However there are scenarios where you don't know the class attributes you will need to manipulate ahead of time. This is where you can use __setattr__ function. However it is not recommended practice. So instead the recommendation is to use Python's build-in method setattr which internally calls the __setattr__ method:

setattr(instance, attribute, value)

Using this approach you can set attributes you don't know ahead of time or you can even loop of some dict and set values from dict:

values = {
    'title': 'This is edit title',
    ...
}
for k, v in values.items():
    setattr(ticket, k, v)

Not sure why the regular notation did not work for. It probably has nothing to do with the method you used to set attributes.

Answer 2

If you know the objects properties before hand you should probably be using the first method. Just assign property values directly.

The second can be useful when you need to dynamically assign a value to a property. Perhaps a user has the ability to change the values of a number of different attributes and you don't know which one will have a value before hand, you can dynamically add values

possible_fields = ['title', 'looser_ticket']
ticket = Ticket.objects.get(pk=1)
for field in possible_fields:
  if request.GET.get(field):
     setattr(ticket, field, request.GET[field])

The "not working" is probably not dependent on the way you are setting values, are you sure that you saved your changes afterwards??