segmentation fault occur and disappear by using the same code

Question

I am getting a segmentation fault error but I really cannot spot where it comes from. So I have a code as following: