If statement running even when not true

Question

I am not sure what I\'m doing wrong here, every time I run it, it goes through the if part even when it\'s not true? So the \'else\' never runs.

#in         


        

Answer 1

There is a problem in the syntax of 'if' statement. Following is the corrected code, where '||' stands for 'or':

if ((choice == "F") || (choice=="f")){
    newNo = numb * 0.2 * 9 + 32;
}else{
    newNo = (numb - 32) / 1.8;
}

Answer 2

Change this if statement

if (choice == "F" or "f"){

to the following

if (choice == "F" or choice == "f"){

Otherwise the right operand of the operator or

"f"

is always equal to true because it is converted to the address of the first character of the string literal that evidently is not equal to 0.

That is your original condition in the if statement looks like

if (choice == "F" or "f" != nullptr){

and indeed "f" != nullptr

Answer 3

The problem is your if Statement:

if (choice == "F" or "f"){

basically, what you say here is: If choise is "F" or if "f". You need to understand: True is everything besides zero (0). "f" is NOT zero, so it is true. You could also wirte (or = ||):

if (coice == "F" || true)

which is the same like:

if (true)

So in order for your code to work, you need:

if (choice == "f" || choice == "F")

That would do what you expect.