Array sorting input [closed]

Answer 1

With this code You are creating an infinite loop.

Instead, you should write:

votecount = kybd.nextInt(); // in the Loop and At End..

gurung is right..

Answer 2

You seem to have created an infinite loop reason being that votecount will never be equal to -1 since you are never changing it inside the loop.

What you need to do is to move the code where you ask and record the vote within the loop. But before doing votes[votecount]++ check to make sure that the user did not input -1 since this will cause an ArrayOutofBoundsException. So you can loop for ever and when the user enters -1 you can break the loop.

Answer 3

Here is how you can read from the console and fill up the votes array:

public static void main (String[] args){

    String line = null;
    int val = 0;
    BufferedReader is = new BufferedReader(new InputStreamReader(System.in));
    do{
        System.out.println("Usage: Enter votes. Enter -1 to exit");
        int voteNumber = 0; 
        while(voteNumber<5){ 
              try {
                line = is.readLine();
                val = Integer.parseInt(line);
                votes[voteNumber] = val;
                voteNumber++;
              } catch (NumberFormatException ex) {
                System.err.println("Not a valid number: " + line);
                System.out.println("Usage: Enter votes. Enter -1 to exit");
              } 
        }
    }while(val != -1);
}

Answer 4

I would do it like this:

import java.util.Scanner;

public class VoteCount {

    public static void main(String[] args) {
        //create empty array
        int[] votes = new int[5];
        //initialise with 0
        for (int i=0; i<5; i++){
            votes[i] = 0;
        }

        //input data
        input(votes);

    }

    public static void input(int[] votes) 
    {
        System.out.println("Enter vote number of the candidate results: ");
        Scanner kybd = new Scanner(System.in);
        int votecount = kybd.nextInt();
        while (votecount !=-1) {
            votes[votecount]++;  
            System.out.println("Candidate " + votecount +" Has " +votes[votecount] + " votes");
            System.out.println("Enter vote number of the candidate results: ");
            votecount = kybd.nextInt();
        }

    }
}

Now you have to add the functionality that the user is not allowed to enter anything above 4 and below -1, otherwise you will get an exception. Good luck!