Rock Paper Scissors - Python 3 - beginner

Question

I\'m suppose to simulate a rock paper scissors game and this is what I have so far. It\'s not letting me input letters into the scoregame function. How can I fix th

Answer 1

You are using letters without quotes so its looking for a Variable called P but what you want is a String "P" so put the letters in quotes:

if player1 == "P" and player2 == "S":

Answer 2

You need to test against strings; you are now testing against variable names:

if player1 == 'R' and player2 == 'R':

but you can simplify the case where both players picked the same option by testing if they are equal:

if player1 == player2:
    scoregame = "It's a tie, nobody wins."

Next, I'd use a mapping, a dictionary, to codify what beats what:

beats = {'R': 'S', 'S': 'P', 'P': 'R'}

if beats[player1] == player2:
    scoregame = "Player 1 wins."
else:
    scoregame = "Player 2 wins."

Now your game can be tested in just 2 tests. All put together:

def scoregame(player1, player2):
    beats = {'R': 'S', 'S': 'P', 'P': 'R'}
    if player1 == player2:
        scoregame = "It's a tie, nobody wins."
    elif beats[player1] == player2:
        scoregame = "Player 1 wins."
    else:
        scoregame = "Player 2 wins."
    print(scoregame)