C# output different from breakpoint output [duplicate]

Answer 1

Check this link. They describe it beautifully The problem is that you are creating instances of the Random class too close in time.

When you create a Random object, it's seeded with a value from the system clock. If you create Random instances too close in time, they will all be seeded with the same random sequence.

Create a single Random object and pass its reference to the constructor when you create instances of the "a" class, instead of creating one Random object for each "a" instance.

Answer 2

 public static void LoadCards()
 {
     Deck deck = new Deck();
     for (int i = 0; i < 24; i++)
     {
         Random r = new Random();
         YourDeck.Add(deck.CardNames[r.Next(0, 14)]);
     }
  }

Your Random class should not be created in the foreach loop. If you keep initalizing random within the foreach loop when it seeds itself to produce random number you keep starting that sequence over based on time of system clock. If you place it outside the foreach loop it will maintain it's initial seed data and produce numbers without reseeding back to the first one.

So your code would look like this:

 public static void LoadCards()
 {
     //Random initialized outside of the foreach loop
     Random r = new Random();
     Deck deck = new Deck();
     for (int i = 0; i < 24; i++)
     {
         YourDeck.Add(deck.CardNames[r.Next(0, 14)]);
     }
  }

Documentation on default constructor for Random.

Answer 3

You should create the Random before the loop.

public static void LoadCards()
{
    Deck deck = new Deck();
    Random r = new Random();
    for (int i = 0; i < 24; i++)
    {
        YourDeck.Add(deck.CardNames[r.Next(0, 14)]);
    }
}

The default constructor of Random

Initializes a new instance of the Random class, using a time-dependent default seed value.

The default seed value is derived from the system clock and has finite resolution. As a result, different Random objects that are created in close succession by a call to the default constructor will have identical default seed values and, therefore, will produce identical sets of random numbers.