Basically i have two files with strings in them separated with a new line.
What i wish to do is get the first string from the first file and compare it to ALL of the str
Your code works correctly, if you're looking for a more elegant way I would either suggest a bash script or looking at the array_map function (possibly other ones like array_walk, array_filter too.)
That being said, your code is simple and easy to follow so probably the best way to go.
Well there is a more efficient way to achieve this. Using array_intersect you can find the common lines between this two files.
$a = file('file1.txt');
$b = file('file2.txt');
$c = array_intersect($a, $b);
Whatever lines which are common between the two files are found in the $c
array. However do note that the intersection is case sensitive.