Creating a function from current source code “list comprehension”

Question

Ive been working on this code which seems quite simple. When you run the code from a static list as presented my code works fine. When I run the code on a live list that appends