rand() generating the same number [duplicate]

Answer 1

Your calls to die.roll() are so close together that time(0) is actually returning the same value every time, and, thus, your rand seed is the same for each call to .roll().

Try calling srand(static_cast<int>(time(0))); once (and only once) outside of .roll() (like in the Die constructor or main()).

Answer 2

You need to initialize the random generator with a "truly random" (or at least unique) seed, and do it only once.

This is usually done with srand(time(NULL)) at the beginning.

Numbers generated by rand() are not random, they are *pseudo*random: given the same seed, it will always return the same sequence. By default, I believe the initial seed is zero (however, it is for sure always the same between program runs - so without seeding you'll always get the same apparently random sequence every time).

Answer 3

As emartel pointed out, the only real change you need is to call time(NULL) instead of time(0).

Alternately you could call srand(time(NULL)) in the constructor and then just use rand() in roll().