How would I optimize these for loops in Arduino code?

Question

Quickly wrote this code to fade an RGB led through the whole RGB spectrum (I think) and wondered if there is a more efficient way of coding everything in the main loop? It seems