Why is my code not giving me correct results

Question

I have this code that is supposed to swap between two consecutive strings in an array of strings. I am getting this output:

adf
nmmmmmmm
gh
11kk%$#
abcd