If i was using a concurrent hashmap and i had methods which set and got values, as im using a concurrent hashmap would i need to make the getter and setter synchronized? Is
java.util.concurrent.ConcurrentHashMap
is thread safe synchronized(object)
You still need to be careful not to create a "logical" race condition by code like this
if (map.get(key) != null) {
map.put(key, new SomethingStrictlyUnique());
}
As a rule of thumb, replacing synchronized collections with concurrent collections can offer dramatic scalability improvements with little risks.
According to the javadoc, iterators returned by ConcurrentHashMap are "weakly consistent" (instead of fail-fast), so they tolerate concurrent modification, traverse elements as they existed when the iterator was constructed, and may reflect modifications to the collection after the construction of the iterator.
1) If you've getter & setter methods which does only one operation (like get method will only return the map value for the given key) or any thread-safe operation, then you don't need an explicit synchronized block for those getter & setter.
2) Yes, using concurrent hashmap without synchronized block will greatly improve performance.
Note : ConcurrentHashMap is weakly consistent which is acceptable in most cases.