What are the pros and cons between these two approaches of C++ constructors [closed]