Creating a prototype on string and the usage of 'this'

Question

I am playing around with prototypes and making a prototype on String that will add dashes between each character. The following works but the example below that was my orig