Java - “String index out of range” exception

Question

I wrote this little function just for practice, but an exception (\"String index out of range: 29\") is thrown and I don\'t know why...

(I know this isn\'t the best

Answer 1

This exception is an IndexOutOfBoundsException but more particularly, a StringIndexOutOfBoundsException (which is derived from IndexOutOfBoundsException). The reason for receiving an error such as this is because you are exceeding the bounds of an indexable collection. This is something C/C++ does not do (you check bounds of collections manually) whereas Java has these built into their collections to avoid issues such as this. In this case, you're using the String object like an array (probably what it is in implementation) and going over the boundary of the String.

Java does not expose the null terminator in the public interface of String. In other words, you cannot determine the end of the String by searching for the null terminator. Rather, the ideal way to do this is by ensuring you do not exceed the length of the string.

Answer 2

a much better implementation (with regex) is simply return y.replaceAll("\\s+"," "); (this even replaces other whitespace)

and StringBuffer.length() is constant time (no slow null termination semantics in java)

and similarly x.charAt(x.length()); will also throw a StringIndexOutOfBoundsException (and not return \0 like you'd expect in C)

for the fixed code:

while ( y.length()>i)//use length from the buffer
{
    if (y.charAt(i) != ' ')
    {
        y.setCharAt(j, y.charAt(i));
        i++;
        j++;
    }
    else
    {
        y.setCharAt(j, y.charAt(i));
        i++;
        j++;
        while (y.charAt(i) == ' ')
            i++;
    }           
}
y.setLength(j);//using setLength to actually set the length

btw a StringBuilder is a faster implementation (no unnecessary synchronization)

Answer 3

Looks like you are a C/C++ programmer coming to java ;)

Once you have gone out of range with .charAt (), it doesn't reach null, it reaches a StringIndexOutOfBoundsException. So in this case, you will need a for loop that goes from 0 to y.length()-1.

Answer 4

Are you translating this code from another language? You are looping through the string until you reach a null character ("\0"), but Java doesn't conventionally use these in strings. In C, this would work, but in your case you should try

i < y.length()

instead of

y.charAt(i) != '\0'

---

Additionally, the

 y.setCharAt(j,'\0')

at the end of your code will not resize the string, if that is what you are expecting. You should instead try

y.setLength(j)

Answer 5

Java strings are not null-terminated. Use String.length() to determine where to stop.