Rock, Paper, Scissor game - how to end when one wins three times?

Question

I am writing a Rock(Sten), Paper(Påse), Scissor(Sax) game, that plays against the computer. It works and all but I want to break the game when one off the two wins three tim

Answer 1

Instead of trying to fix your code with the current methods I would suggest adding the following to make your code easier to follow:

1: Use enums to give a clear meaning to numbers.

public enum Choice
{
    Rock,
    Paper,
    Scissor
}

public enum WinResult
{
    Won,
    Tie,
    Lost
}

2: Add a method to ask input from user and return the result.

private Choice GiveChoice()
{
    // This is a label where we can jump to if the input was invalid.
    start:

    // Ask the question.
    Console.Clear();
    Console.WriteLine("Choose (0:Rock, 1:Paper, 2:Scissor):");
    string answer = Console.ReadLine();
    int result = -1;

    // Validate and re-ask if invalid.
    if (!int.TryParse(answer, out result) || (result < 0 && result > 2))
        goto start;

    return (Choice) result;
}

3: Add a method to compare 2 results from eachother.

// Returns if v1 has won, tied or lost from v2. (Left to right)
private WinResult CompareForWinner(Choice v1, Choice v2)
{
    if (v1 == Choice.Paper)
    {
        if (v2 == Choice.Paper)
            return WinResult.Tie;
        if (v2 == Choice.Rock)
            return WinResult.Lost;

        return WinResult.Won;
    }
    if (v1 == Choice.Rock)
    {
        if (v2 == Choice.Paper)
            return WinResult.Lost;
        if (v2 == Choice.Rock)
            return WinResult.Tie;

        return WinResult.Won;
    }

    // v1 = Scissor.
    if (v2 == Choice.Paper)
        return WinResult.Won;
    if (v2 == Choice.Rock)
        return WinResult.Lost;

    return WinResult.Tie;
}

It's not a direct answer to your question. But I think it will help you solve it yourself.

Answer 2

Surely the answer to this question should be go and read a book on programming c#?

I noticed that this is marked as a Duplicate above. When you go to that Duplicate that too is marked as a duplicate and only 11 hours ago.

I really don't think people should be just posting up their homework....

Answer 3

So it looks like the problem is that in your Poang method you check to see if someone has won 3 times and if so display a message, but after you check that you don't terminate the program. It just keeps going on as if nothing happened. Also, your win count variables are locally scoped, so they lose their value every time the function ends.

There are a lot of things that could be done to make this program better, however I am just going to provide the simplest fix here:

    public void UtseVinnare(string _Val)
    {
        string SpelareVal = _Val;
        string _SpelarVal = _Val.ToUpper();
        string _DatornsVal = DatornsVal.ToUpper(); 

        if (_DatornsVal == _SpelarVal)
        {
            Interaction.MsgBox("Oavgjort!\nDitt val var: " + SpelareVal + "\n" + "Datorns val var: " + DatornsVal);
            string Val = Interaction.InputBox("Välj Sten, Sax eller Påse:");
            Starta();
            UtseVinnare(Val);
        }

        else if (_DatornsVal == "STEN" && _SpelarVal == "SAX" || _DatornsVal == "SAX" && _SpelarVal == "PÅSE" || _DatornsVal == "PÅSE"
            && _SpelarVal == "STEN")

        {
            Interaction.MsgBox("Du förlorade!\nDitt val var: " + SpelareVal + "\n" + "Datorns val var: " + DatornsVal);
            int spelare = 0;
            int dator = 1;
            if (Poang(dator, spelare))
            {
                return;
            }
            string Val = Interaction.InputBox("Välj Sten, Sax eller Påse:");
            Starta();
            UtseVinnare(Val);
        }

        else if (_DatornsVal == "STEN" && _SpelarVal == "PÅSE" || _DatornsVal == "SAX" && _SpelarVal == "STEN" || _DatornsVal == "PÅSE"
            && _SpelarVal == "SAX")
        {

            Interaction.MsgBox("Du vann!\nDitt val var: " + SpelareVal + "\n" + "Datorns val var: " + DatornsVal);
            int spelare = 1;
            int dator = 0;
            if (Poang(dator, spelare))
            {
                return;
            }
            string Val = Interaction.InputBox("Välj Sten, Sax eller Påse:");
            Starta();
            UtseVinnare(Val);
        }


    }

    int datorpoangraknare = 0;
    int spelarpoangraknare = 0;

    public bool Poang(int _dator, int _spelare)
    {
        if (_dator > _spelare)
        {
            datorpoangraknare++;
        }
        else
        {
            spelarpoangraknare++;
        }
        if (datorpoangraknare == 3)
        {
          Interaction.MsgBox("Datorn vann tre gånger!");
          return true;
        }
        if (spelarpoangraknare == 3)
        {
            Interaction.MsgBox("Du vann tre gåger!");
            return true;
        }
        return false;
    }