How to properly allocate memory in a loop using vector?

Question

Im working with the creation of the abstract syntax tree for a specific domain language. So the snippet here just allocating a memory for the children of the node. However,