Why does this Arduino while loop never end?

Question

This may be the worst way of doing this but I want the Arduino to pick between 1 and -1. This code is not working, what is wrong.

This is my understanding of the code