What is the recommended method for documenting a class method that accepts a variable number of arguments?
Maybe something like this?
Something worth noting is that with a doc block such as:
/**
* @param Type[] ...$values One or more values.
*/
public function func(Type ...$values) {
// ...
}
...it might seem like you could pass an array of Type
, e.g.
Foo()->func([Type, Type, Type])
...this throws a fatal error, obviously now.
Where:
Foo()->func(...[Type, Type, Type])
...does not as you have destructured it on method call.
Anyway the point here is that I was experimenting with how PHPStorm would treat the doc block and depending on the way in which you orient your $args
variable in your doc block, with either ...$args
or $args,...
determines the type of hints you get back in your IDE.
I'd really like a way to suggest the values you should pass by name into the method in the exemplified image below in the case where you have an optional length of function/method parameters, with a specific order in which they should be passed.
You might think, "just set default args, $arg1 = 'default', $arg2 = true
" which typically makes sense but in cases
Pseudo-example:
/**
* @param int ...$args Hour, Minute, Second, Timezone, $arg [, ...$args]
*/
public static function createA(int ...$args) {}
/**
* @param int $args,... Hour, Minute, Second, Timezone, $arg [, ...$args]
*/
public static function createB(int ...$args) {}
/**
* @param int[]|int $args,... Hour, Minute, Second, Timezone, $arg [, ...$args]
*/
public static function createC(int ...$args) {}
...so either of:
...is the correct answer (just keeping in mind orientaton: ...$args
or $args,...
)
In the case of the ... syntax, PHPStorm 2017.1 uses:
/**
* @param Type[] ...$values One or more values.
*/
public function func(Type ...$values) {
// ...
}
/**
* @param mixed $numbers,... Description
*/
Public function sum ($numbers)
In the method, $numbers will not be used.
If your using a variable number of arguments and also using PHP >= 5.6
then you are able to use variadic functions (allowing variable number of arguments) which still conforms to the PHPDoc ,...
syntax already mentioned and PHPStorm will interpret the docs properly as well. Using variadic functions eliminates needing func_get_args()
to capture arguments into an array.
/**
* @param mixed $args,... Explainatorium!
*/
function variadiculous(...$args) {
// NOTE: $args === func_get_args()
foreach ( $args as $arg ) {
/* do work */
}
}
PHPStorm will auto-generate the docs as @param array $args
because technically when inside the function variadiculous
is_array($args)
is true. I change it to read @param mixed $args,...
as above and when I use the hotkey to display a function signature from somewhere else in my code PHPStorm displays variadiculous($args : ...array|mixed)
-- I recommend using this method if your using PHP >= 5.6