Ignore Spaces Using getline in C++ [duplicate]

Answer 1

@Vladimir is right. Here is the mechanism behind the bug:

When you enter option '3', what you actually put into stream is "3\n". cin >> option consumes "3" and leaves "\n". getline() consumes "\n" and your call to ignore() after getline() waits for user input.

As you can see, teh sequence of events is already not what you expected.

Now, while ignore() is waiting for input, you type in your line. That line you're typing is what will go to "cin >> option.

If you just give it one symbol, ignore() will dispose of it for you, and option will be read correctly. However, if you give it non-numeric symbols, stream will set failbit when trying to read the option. From that point on, your stream will refuse to do anything. Any << or getline will not set any new values in the variables they are supposed to change. You'll keep 3 in option and "" in task, in a tight loop.

Things to do:

• always check cin.eof(), cin.fail() and cin.bad().
• always initialize your variables and declare them in the narrowest scope possible (declare option=0 right before it's read).

Answer 2

I just figured out a way to kind of hack through it, not the greatest but it works. Create a character array, and then accept input in the array, and then put everything into the array into the string.

char buff[256];
            cout << endl << "Enter the task that you would like to add:" << endl;
            cin >> task;
            task += " ";
            cin.getline(buff, 256);
            for(int i = 1; buff[i] != 0; i++){
                task += buff[i];
            }

Answer 3

Don't do this:

    while(myfile.good())
    {
        getline(myfile,inputLine);
        list.push(inputLine);
    }

The EOF flag is not set until you try and read past the EOF. The last full line read read up-to (bit not past) the EOF. So if you have have zero input left myfile.good() is true and the loop is enetered. You then try and read a line and it will fail but you still do the push.

The standard way of reading all the lines in a file is:

    while(getline(myfile,inputLine))
    {
        list.push(inputLine);
    }

This way the loop is only entered if the file contained data.

Your other problem seems to stem from the fact that you have:

 std::getline(std::cin,task); // THIS is OK
 std::cin.ignore();           // You are ignoring the next character the user inputs.
                              // This probably means the next command number.
                              // This means that the next read of a number will fail
                              // This means that std::cin will go into a bad state
                              // This means no more input is actually read.

So just drop the cin.ignore() line and everything will work.

Answer 4

Instead of using ">>" directly on your stream you might consider using getline and then attempting to fetch your option from that. Yes, it's less "efficient" but efficiency isn't generally an issue in such situations.

You see, the problem is that the user could enter something silly here. For example, they could enter something like "two", hit enter, and then your program is going to pitch a fit as it happily continues trying to decipher an empty option over and over and over and over again. The user's only recourse the way you have it set up (and the way those recommending use of ignore() are recommending) is to kill your program. A well behaved program doesn't respond in this way to bad input.

Thus your best option is not to write brittle code that can seriously break down with the most modest of user ignorance/malfunction, but to write code that can handle error conditions gracefully. You can't do that by hoping the user enters a number and then a newline. Invariably, someday, you'll bet poorly.

So, you have two options to read your option. First, read a full line from the user, make sure the stream is still good, and then turn the string you get into a stream and try to read your integer out of it, making sure this other stream is still good. Second option, attempt to read a number, verify that the stream is still good, read a line and make sure the stream is still good and that your string is empty (or just ignore it if it isn't, your choice).

Answer 5

You have to add cin.ignore() right after options is chosen:

//get the input from the user
cin >> option;
cin.ignore();

And cin.ignore() is not necessary after your getline:

    getline(cin, task); // THIS IS WHERE THE ISSUE COMES IN
        //cin.ignore();

The problem is in options - if you didn't call cin.ignore() after it, options will contain end of line and loop will continue...

I hope this helps.