At the beginning of my code, there is:
List> result = new ArrayList();
And then, (here is to reverse a sub-list):
Think of it like this, you have a Fruit
called re
(I use this name because it's the name of the variable you are using).
Fruit re;
You have a method reverse
whose input type is Apple
.
public Apple reverse(Apple a) {
// ...
}
We have a variable re
that we declared as Fruit
which means we're saying it's always going to be some kind of Fruit
, perhaps Apple
, but maybe Orange
-- or even Banana
.
When you try to give the Fruit
to the method taking Apple
the compiler stops you, because it can't be certain that it's 100% an Apple
. For example...
Fruit re = new Orange();
reverse(re);
Yikes! We are putting a square peg into a round hole so to speak. reverse
takes Apple
, not Orange
. Bad things could happen!
Side note: Why is it okay then to assign
Apple
to something declared asFruit
then? (reverse
returns anApple
,Fruit f = reverse(re);
is legal.) Because anApple
is aFruit
. If it were declared as the more specificApple
and the return type were the more generalFruit
, then there would be an issue here. (Ifreverse
returnedFruit
,Apple a = reverse(re);
would be illegal.)
If you didn't follow the metaphor, replace Fruit
with List
and Apple
with ArrayList
and read the above again. List
is Fruit
, a general way to describe an abstract idea. ArrayList
is Apple
, a specific implementation of the abstract idea. (LinkedList
could be Orange
too.)
In general you want to declare things as the most general thing you can to get the functionality you need. Making the below change should fix your problem.
public List<Integer> reverse(List<Integer> list) {
We are taking some kind of List
of Integer
s and returning some kind of List
of Integer
s.
It's because your result varible has a type of List, but your method want an ArrayList Try it with:
List<ArrayList<Integer> result = new ArrayList<>();
or change your function in:
public List<Integer> reverse(List<Integer> list){...
You're using a specific implementation of the List
interface as a return type for the reverse
function (namely ArrayList
). This forces what you return to be an ArrayList
, but you're defining it as List
.
To understand, try and change the construction part to use a LinkedList
, which also implements List
:
List<Integer> newList = new LinkedList<Integer>();
This construction is valid, but now we try and return a LinkedList
from a function that returns an ArrayList
. This makes no sense since they aren't related (But notice this: they both implement List
).
So now you have two options:
Make the implementation more specific by forcing use of ArrayList
s:
ArrayList<Integer> newList = new ArrayList<>();
Or better, make the implementation more general by changing the function's return type (any List
can be plugged in):
public List<Integer> reverse(List<Integer> list){