I was playing around with Constrained Execution Regions tonight to better round out my understanding of the finer details. I have used them on occasion before, but in those
I think I at least have a theory as to what is going on. If the while
loop is changed to put the thread into an alertable state then the ThreadAbortException
is injected even with a CER setup.
RuntimeHelpers.PrepareConstrainedRegions();
try
{
// Standard abort injections are delayed here.
Thread.Sleep(1000); // ThreadAbortException can be injected here.
// Standard abort injections are delayed here.
}
finally
{
// CER code goes here.
// Most abort injections are delayed including those forced by the CLR host.
}
So PrepareConstrainedRegions
will demote aborts issued from Thread.Abort
while inside the try
block so that it behaves more like Thread.Interrupt
. It should be easy to see why this would make the code inside try
a little safer. The abort is delayed until a point is reached where data structures are more likely to be in a consistent state. Of course, this assumes that a developer does not intentionally (or unintentionally for that matter) put the thread into an alertable state in the middle of updating a critical data structure.
So basically PrepareConstrainedRegions
has the added undocumented feature of further constraining when aborts will get injected while inside a try
. Since this feature is not documented it is prudent for developers to avoid relying on this assumption by not putting critical code in the try
block of a CER construct. As documented only the catch
, finally
, and fault
(not in C#) blocks are formally defined as the scoping of a CER.
Your unexpected behavior is due to the fact that your code has the maximum reliability.
Define the following methods:
private static bool SwitchToggle(bool toggle) => !toggle;
[ReliabilityContract(Consistency.WillNotCorruptState,Cer.Success)]
private static bool SafeSwitchToggle(bool toggle) => !toggle;
And use them instead of the body of your while cycle. You will notice that when calling SwitchToggle the cycle becomes abortable and when calling SafeSwitchToggle it is no more abortable.
The same goes if you add whichever other methods inside the try block that is not having a Consistency.WillNotCorruptState or Consistency.MayCorruptInstance.
[Cont'd from comments]
I will break my answer into two parts: CER and handling ThreadAbortException.
I don't believe a CER is intended to help with thread aborts in the first place; these are not the droids you're looking for. It's possible I'm misunderstanding the statement of the problem as well, this stuff tends to get pretty heavy, but the phrases I found to be key in documentation (admittedly, one of which was was actually in a different section than I mentioned) were:
The code cannot cause an out-of-band exception
and
user code creates non-interruptible regions with a reliable try/catch/finally that *contains an empty try/catch block* preceded by a PrepareConstrainedRegions method call
Despite not being inspired directly in the constrained code, a thread abort is an out-of-band exception. A constrained region only guarantees that, once the finally is executing, as long as it obeys the constraints it has promised, it will not be interrupted for managed runtime operations that would otherwise not interrupt unmanaged finally blocks. Thread Aborts interrupt unmanaged code, just as they interrupt managed code, but without constrained regions there are some guarantees and probably also a different recommended pattern for the behavior you may be looking for. I suspect this primarily functions as a barrier against thread suspension for Garbage Collection (probably by switching the Thread out of Preemptive garbage collection mode for the duration of the region, if I had to guess). I could imagine using this in combination with weak references, wait handles, and other low level management routines.
As for the unexpected behavior, my thoughts are that you did not meet the contract you promised by declaring the constrained region, so the result is not documented and should be considered unpredictable. It does seem odd that the Thread Abort would be deferred in the try, but I believe this to be a side-effect of unintended usage, which is only worth exploring further for academic understanding of the runtime (a class of knowledge that is volatile, since there is no guarantee of the behavior future updates could change this behavior).
Now, I'm not sure what the extent of said side effects are in using the above-mentioned in unintended ways, but if we exit the context of using the force to influence our controlling body and let things run the way they normally would, we do get some guarantees:
With that, here is a sample of techniques meant to be used in cases where abort resiliency is necessary. I have mixed multiple techniques in a single sample which are not necessary to use at the same time (generally you wouldn't) just to give you a sampling of options depending on your needs.
bool shouldRun = true;
object someDataForAnalysis = null;
try {
while (shouldRun) {
begin:
int step = 0;
try {
Interlocked.Increment(ref step);
step1:
someDataForAnalysis = null;
Console.WriteLine("test");
Interlocked.Increment(ref step);
step2:
// this does not *guarantee* that a ThreadAbortException will not be thrown,
// but it at least provides a hint to the host, which may defer abortion or
// terminate the AppDomain instead of just the thread (or whatever else it wants)
Thread.BeginCriticalRegion();
try {
// allocate unmanaged memory
// call unmanaged function on memory
// collect results
someDataForAnalysis = new object();
} finally {
// deallocate unmanaged memory
Thread.EndCriticalRegion();
}
Interlocked.Increment(ref step);
step3:
// perform analysis
Console.WriteLine(someDataForAnalysis.ToString());
} catch (ThreadAbortException) {
// not as easy to do correctly; a little bit messy; use of the cursed GOTO (AAAHHHHHHH!!!! ;p)
Thread.ResetAbort();
// this is optional, but generally you should prefer to exit the thread cleanly after finishing
// the work that was essential to avoid interuption. The code trying to abort this thread may be
// trying to join it, awaiting its completion, which will block forever if this thread doesn't exit
shouldRun = false;
switch (step) {
case 1:
goto step1;
break;
case 2:
goto step2;
break;
case 3:
goto step3;
break;
default:
goto begin;
break;
}
}
}
} catch (ThreadAbortException ex) {
// preferable approach when operations are repeatable, although to some extent, if the
// operations aren't volatile, you should not forcibly continue indefinite execution
// on a thread requested to be aborted; generally this approach should only be used for
// necessarily atomic operations.
Thread.ResetAbort();
goto begin;
}
I'm no expert on CER, so anybody please let me know if I've misunderstood. I hope this helps :)