C# Add Values to List of Strings

Question

When I run the function GetPicklistData the list is empty. When I go through the debugger it appears that it is adding data to the list but when its done looping there is no