Why does EnumSet have many overloaded “of” methods?

Question

While going through the EnumSet of method, I have seen multiple overloaded implementations of of method:

publ         


        

Answer 1

From the javadoc:

Overloadings of this method exist to initialize an enum set with one through five elements. A sixth overloading is provided that uses the varargs feature. This overloading may be used to create an enum set initially containing an arbitrary number of elements, but is likely to run slower than the overloadings that do not use varargs.

Answer 2

varags creates an array, that is when we call

void x(int...x) {...}
..
x(1);

Compiler replaces last line with this:

x(new int[] {1});

It will not happen if we have an overloaded method with 1 arg:

void x(int...x) {...}
void x(int x) {...}

Then compiler will choose the second method.

Answer 3

Varargs methods create an array.

public static void foo(Object... args) {
  System.out.println(args.length);
}

This works, because of the implicit array creation. EnumSet is a class designed to be very, very fast, so by creating all the extra overloads they can skip the array creation step in the first few cases. This is especially true since in many cases Enum don't have that many elements, and if they do, the EnumSet might not contain all of them.

Javadoc for EnumSet<E> of(E e1, E e2, E e3, E e4, E e5):

Creates an enum set initially containing the specified elements. Overloadings of this method exist to initialize an enum set with one through five elements. A sixth overloading is provided that uses the varargs feature. This overloading may be used to create an enum set initially containing an arbitrary number of elements, but is likely to run slower than the overloadings that do not use varargs.

Answer 4

Because that class was designed by Josh Bloch, and that guy knows how things work. :) Besides creating an array, the varargs method contains the loop, which is more work for the JIT to optimize the code.

For example, if we look at the implementation of the overloaded version with five parameters:

result.add(e1);
result.add(e2);
result.add(e3);
result.add(e4);
result.add(e5);

we notice that it is some kind of an already unrolled loop that could look like:

for (E e : Arrays.asList(e1, e2, e3, e4, e5)) {
   result.add(e);
}

Also, shorter and simpler methods are more likely to be inlined than longer and more complex ones.