How can you add commits to a github pull request of another person to your repo if you can't commit to their branch?

前端 未结 3 537
粉色の甜心
粉色の甜心 2020-12-25 11:22

Here\'s the scenario:

I have a public repo A. Bob forks A, adds a few commits to Bob/master and submits a pul

相关标签:
3条回答
  • 2020-12-25 11:41

    One solution is to make a PR into Bob/master containing your revisions. Bob can merge your PR into Bob/master; when you merge Bob's PR into A/master, it will contain Bob's commits and your commits.

    You can create a PR from any fork/branch to any other fork/branch. So if Bob submits a PR from Bob/feature, just create a PR into Bob/feature.

    0 讨论(0)
  • 2020-12-25 11:47

    There are a number of workflows you can use here. Some examples are:

    1. Comment on the pull request, and have Bob make some changes. See Pull Request Discussion for more info.

    2. Merge the pull request onto a different branch, then make your changes before merging to master. You need to do this from the command line; see Merging a Pull Request for step-by-step instructions.

    3. Edit the patch before applying it with git am. See Patch and Apply. This is probably the most flexible option, but also the most manual.

      git checkout master
      curl http://github.com/<username>/<project_name>/pull/<patch_number>.patch
      sensible-editor <patchfile>
      git am <patchfile>
      git push origin master
      
    0 讨论(0)
  • 2020-12-25 11:50

    You can just pull from his branch on your local repo (not inside the github gui)

    # make same work-in-progress branch and check it out
    $ git checkout -b WIP
    
    # pull his changes into WIP
    $ git pull https://github.com/... master
    

    and then mercilessly change from there on.

    The other option would be to use github's comment system to talk him into changing his patchset (that way he could also keep the credit after the merge).

    0 讨论(0)
提交回复
热议问题