App crashes while calling LocationUpdatesService with permission with NullPointerException

Question

I\' trying to implement Google\'s android foreground location sample from github in my application. It works fine in the first run of the application. It requests for locati

Answer 1

I am not sure, but try this:

@Override
    protected void onStart() {
        super.onStart();
        PreferenceManager.getDefaultSharedPreferences(this)
                .registerOnSharedPreferenceChangeListener(this);

        if (!checkPermissions()) {
            requestPermissions();
        } else if (mService != null) { // add null checker
            mService.requestLocationUpdates();
        }
        // Bind to the service. If the service is in foreground mode, this signals to the service
        // that since this activity is in the foreground, the service can exit foreground mode.
        bindService(new Intent(this, LocationUpdatesService.class), mServiceConnection,
                Context.BIND_AUTO_CREATE);
    }

Also:

private final ServiceConnection mServiceConnection = new ServiceConnection() {
        @Override
        public void onServiceConnected(ComponentName name, IBinder service) {
            LocationUpdatesService.LocalBinder binder = (LocationUpdatesService.LocalBinder) service;
            mService = binder.getService();
            mService.requestLocationUpdates(); // also request it here
            mBound = true;
        }

        @Override
        public void onServiceDisconnected(ComponentName name) {
            mService = null;
            mBound = false;
        }
    };

Answer 2

Update code to this code mService is null because you are initilaizing it after mService.requestLocationUpdates();

 @Override
            protected void onStart() {
                super.onStart();
                PreferenceManager.getDefaultSharedPreferences(this)
                        .registerOnSharedPreferenceChangeListener(this);
        
                if (!checkPermissions()) {
                    requestPermissions();
                } else {
 bindService(new Intent(this, LocationUpdatesService.class), mServiceConnection,
                        Context.BIND_AUTO_CREATE);
                    mService.requestLocationUpdates(); //CRASHING HERE
                }
                // Bind to the service. If the service is in foreground mode, this signals to the service
                // that since this activity is in the foreground, the service can exit foreground mode.
               
            }