Substring a string from the end of the string

Question

I need to remove two characters from the end of the string.

So:

string = \"Hello Marco !\"

must be

Hello Marco


        

Answer 1

I will trim the end for unwanted characters:

s = s.TrimEnd(' ', '!');

To ensure it works even with more spaces. Or better if you want to ensure it works always, since the input text seems to come from the user:

Regex r = new Regex(@"(?'purged'(\w|\s)+\w)");
Match m = r.Match("Hello Marco   !!");
if (m.Success)
{
    string result = m.Groups["purged"].Value;
}

With this you are safer. A purge based on the fact the last two characters has to be removed is too weak.

Answer 2

What about

string s = "Hello Marco !";
s = s.Substring(0, s.Length - 2);

Answer 3

string s = "Hello Marco !";
s = s.Remove(s.length - 2, 2);

Answer 4

Try this:

var s = "Hello Marco !";

var corrected = s.Substring(0, s.Length - 2);

Answer 5

C# 8 introduced indices and ranges which allow you to write

str[^2..]

This is equivalent to

str.Substring(str.Length - 2, str.Length)

In fact, this is almost exactly what the compiler will generate, so there's no overhead.

Note that you will get an ArgumentOutOfRangeException if the range isn't within the string.

Answer 6

s = s.Substring(0, Math.Max(0, s.Length - 2))

to include the case where the length is less than 2