C++ if else if not working properly [duplicate]

Answer 1

Instead of this if(ID =="A"||"a"){, you should write if(ID =="A"|| ID == "a"){ because your statements: if(ID =="A"||"a"){ means if (ID is "A" or the ascii of "a"). The ascii of "a" is bigger than 0, that means it will be read as true value in the if statement. That's why your statement will be equal with if(ID =="A"|| true){ which is why only this statement will be executed.

Answer 2

This is because the expression in the first if is always true:

  ID == "A"  ||  "a"

This does not mean

  ID == "A"  ||  ID == "a"

which is probably what you want instead. The first expression evaluates the left side of the OR and that may be true or false, but the right side is always true: the expression "a" is nonzero, therefore true.

Answer 3

Your problem with if and else if condition.

if(ID =="A"|| ID == "a"){
        com=(sal_val*4.5)/100;
        cout<<"Commission for Apple Rs. " <<com<<endl;}
    else if(ID =="B"||ID == "b"){
        com=(sal_val*5)/100;
        cout<<"Commission for Banana Rs. " <<com<<endl;}
    else if(ID =="O"|| ID == "o"){
        com=(sal_val*5.5)/100;
        cout<<"Commission for Orange Rs. " <<com<<endl;}
    else if(ID =="G"|| ID == "g"){
        com=(sal_val*6)/100;
        cout<<"Commission for Grapes Rs. " <<com<<endl;}

Answer 4

as @user1438832 said in the comments you have to use If(ID=="A"||ID=="a") and follow this format for all your cases

Answer 5

A non zero value with no logical or relational operators in a boolean condition will always return true. So "a" in first if will always return true.That's why only the first if gets executed all the time. Modify you if-else-if as given below:

if(ID =="A"||ID == "a"){
        com=(sal_val*4.5)/100;          
        cout<<"Commission for Apple Rs. " <<com<<endl;}
    else if(ID =="B"||ID == "b"){
        com=(sal_val*5)/100;
        cout<<"Commission for Banana Rs. " <<com<<endl;}
    else if(ID =="O"||ID == "o"){
        com=(sal_val*5.5)/100;
        cout<<"Commission for Orange Rs. " <<com<<endl;}
    else if(ID =="G"||ID == "g"){
        com=(sal_val*6)/100;
        cout<<"Commission for Grapes Rs. " <<com<<endl;}

For comparing a variable with multiple values individual conditions needs to be written in code as written for each of if-else-if construct.