How to assign a value from application.properties to a static variable?

前端 未结 3 1270
执笔经年
执笔经年 2020-12-02 08:18

I am using Spring MVC. I have a UserService class annotated with @Service that has a lot of static variables. I would like to instantiate them with

相关标签:
3条回答
  • 2020-12-02 08:34

    Spring does not allow to inject value into static variables.

    A workaround is to create a non static setter to assign your value into the static variable:

    @Service
    public class UserService {
    
        private static String SVN_URL;
    
        @Value("${SVN_URL}")
        public void setSvnUrl(String svnUrl) {
            SVN_URL = svnUrl;
        }
    
    }
    
    0 讨论(0)
  • 2020-12-02 08:34

    Accessing application.properties in static member functions is not allowed but here is a work around,

    application.properties

    server.ip = 127.0.0.1
    

    PropertiesExtractor.java

    public class PropertiesExtractor {
         private static Properties properties;
         static {
            properties = new Properties();
            URL url = new PropertiesExtractor().getClass().getClassLoader().getResource("application.properties");
            try{
                properties.load(new FileInputStream(url.getPath()));
               } catch (FileNotFoundException e) {
                    e.printStackTrace();
               }
            }
    
            public static String getProperty(String key){
                return properties.getProperty(key);
            }
    }
    

    Main.class

    public class Main {
        private static PropertiesExtractor propertiesExtractor;
        static{
             try {
                 propertiesExtractor = new PropertiesExtractor();
             } catch (UnknownHostException e) {
                   e.printStackTrace();
               }
        }
    
        public static getServerIP(){
            System.out.println(propertiesExtractor.getProperty("server.ip")
        }
    }
    
    0 讨论(0)
  • 2020-12-02 08:47

    Think about your problem for a second. You don't have to keep any properties from application.properties in static fields. The "workaround" suggested by Patrick is very dirty:

    • you have no idea when this static field is modified
    • you don't know which thread modifies it's value
    • any thread at any time can change value of this static field and you are screwed
    • initializing private static field that way has no sense to me

    Keep in mind that when you have bean controlled by @Service annotation you delegate its creation to Spring container. Spring controls this bean lifecycle by creating only one bean that is shared across the whole application (of course you can change this behavior, but I refer to a default one here). In this case any static field has no sense - Spring makes sure that there is only one instance of UserService. And you get the error you have described, because static fields initialization happens many processor-cycles before Spring containers starts up. Here you can find more about when static fields are initialized.

    Suggestion

    It would be much better to do something like this:

    @Service
    public class UserService {
        private final String svnUrl;
    
        @Autowired
        public UserService(@Value("${SVN_URL}") String svnUrl) {
            this.svnUrl = svnUrl;
        }
    }
    

    This approach is better for a few reasons:

    • constructor injection describes directly what values are needed to initialize the object
    • final field means that this value wont be changed after it gets initialized in a constructor call (you are thread safe)

    Using @ConfigurationProperties

    There is also another way to load multiple properties to a single class. It requires using prefix for all values you want to load to your configuration class. Consider following example:

    @ConfigurationProperties(prefix = "test")
    public class TestProperties {
    
        private String svnUrl;
    
        private int somePort;
    
        // ... getters and setters
    }
    

    Spring will handle TestProperties class initialization (it will create a testProperties bean) and you can inject this object to any other bean initialized by Spring container. And here is what exemplary application.properties file look like:

    test.svnUrl=https://svn.localhost.com/repo/
    test.somePort=8080
    

    Baeldung created a great post on this subject on his blog, I recommend reading it for more information.

    Alternative solution

    If you need somehow to use values in static context it's better to define some public class with public static final fields inside - those values will be instantiated when classloader loads this class and they wont be modified during application lifetime. The only problem is that you won't be able to load these values from Spring's application.properties file, you will have to maintain them directly in the code (or you could implement some class that loads values for these constants from properties file, but this sounds so verbose to the problem you are trying to solve).

    0 讨论(0)
提交回复
热议问题