Should I use @ in my PHP code?

Question

If I use @ in my code, will it affect performance?

Answer 1

Yes, it does affect performance of your script in a (significant) way.

Read the article PHP Error Suppression Performance.

Answer 2

You should not use the error suppression operator.

In a production environment, no PHP error messages should be shown to the user. They are not useful, because they are full of technical details and do not tell the user how to proceed. Instead, log the error and show your own error message.

In a development environment, all PHP error messages should be shown to the user. They are a vital clue as to the cause of the problem and should be noticed early.

Use the Errors and Logging Configuration Options to distinguish between theses two. Performance is not a useful criterion to decide whether to use @ or not.

Answer 3

"A foolish consistency is the hobgoblin of little minds." :) To say "never use it" is a bit of an amateurish stance, IMO. I much prefer $var = @$_POST['key'] to $var = isset($_POST['key'])? $_POST['key'] : null;

Answer 4

The @ itself is not the cause of performance problems (which, btw, are mostly unnoticable in profiling graphs). Missing array indicies and undefined variables cause notices/warnings and that's where a slowdown occours. The error suppression operator itself is not at fault.

Using @$var in lieu of the fugly isset($var)?$var:NULL has the advantage of still being able to log debug notices, where isset completely hides them.

Answer 5

Yes, it will decrease your performance when hunting for bugs. So no, you shouldn't use it unless you're sure you won't cause more problems that way.

Answer 6

This article is helpful for answering your question: http://anvilstudios.co.za/blog/php/how-to-ignore-errors-in-a-custom-php-error-handler/

Specifically the section "@ has its uses":

Now one really should use the @ operator very sparingly, handling errors instead of suppressing them. But there are a small number of situations I can think of where one might need to suppress some PHP errors. Let me offer two examples :

• You could be using some large external library which has made use of the @, and so need to be able to ignore those errors as the author of the library intended, otherwise your program is going to trip up where it doesn’t need to. You could edit the library, but it might take a lot of time, and your changes would again have to be applied each time the author releases an update to the library.

• Another example might be when the fopen function is used to open an external URL, and the URL cannot be opened for one of many possible reasons. The function returns false to indicate a fail, which is great, but to quote the PHP manual, "an error of level E_WARNING is generated" too, not so great — it should really result in an exception being thrown instead, as this is an irregular situation, but one which should be expected. In this case one would like to be able to ignore the error, and continue with the program execution, explicitly responding in an appropriate way – exactly what exceptions are for! There is, however, a way to convert the error to an exception and so avoid using the @ in this situation. In your custom error handler (which is where we find ourselves in this post), throw an ErrorException – this then requires you to explicitly catch and handle it in the code that was using the @ before, which is a better way of handling errors.