Adding items to a LIST<> of objects results in duplicate Objects when using a NEW in a Loop

Question

List bolList = new List();

protected void Button1_Click(object sender, EventArgs e)
{
    BillOfLading newBol = new BillOfLa         


        

Answer 1

Flynn1179's answer is correct, but to answer your comment - you don't need a different variable for each object. You can do:

protected void Button1_Click(object sender, EventArgs e)
{
    BillOfLading newBol = new BillOfLading("AXSY1414114");
    bolList.Add(newBol);

    newBol = new BillOfLading("CRXY99991231");
    bolList.Add(newBol);
}

The important thing to understand is that you're not adding the variable to the list, nor are you adding the object to the list... you're adding the current value of the variable to the list. That current value is a reference to an instance of BillOfLading. In the above code, the list ends up with references to two different objects.

Answer 2

You've only created one object, and added it twice. The fact that you modified that object between the first and second add is irrelevant; the list contains a reference to the object you added, so later changes to it will apply.

You need to replace newBol.BillOfLadingNumber = ".."; with newBol = new BillOfLading("..");