Why not use exceptions as regular flow of control?

后端 未结 24 1850
心在旅途
心在旅途 2020-11-21 07:30

To avoid all standard-answers I could have Googled on, I will provide an example you all can attack at will.

C# and Java (and too many others) have with plenty of ty

相关标签:
24条回答
  • 2020-11-21 08:03

    Because the code is hard to read, you may have troubles debugging it, you will introduce new bugs when fixing bugs after a long time, it is more expensive in terms of resources and time, and it annoys you if you are debugging your code and the debugger halts on the occurence of every exception ;)

    0 讨论(0)
  • 2020-11-21 08:03

    You can use a hammer's claw to turn a screw, just like you can use exceptions for control flow. That doesn't mean it is the intended usage of the feature. The if statement expresses conditions, whose intended usage is controlling flow.

    If you are using a feature in an unintended way while choosing to not use the feature designed for that purpose, there will be an associated cost. In this case, clarity and performance suffer for no real added value. What does using exceptions buy you over the widely-accepted if statement?

    Said another way: just because you can doesn't mean you should.

    0 讨论(0)
  • 2020-11-21 08:05

    Here are best practices I described in my blog post:

    • Throw an exception to state an unexpected situation in your software.
    • Use return values for input validation.
    • If you know how to deal with exceptions a library throws, catch them at the lowest level possible.
    • If you have an unexpected exception, discard current operation completely. Don’t pretend you know how to deal with them.
    0 讨论(0)
  • 2020-11-21 08:05

    One aesthetic reason:

    A try always comes with a catch, whereas an if doesn't have to come with an else.

    if (PerformCheckSucceeded())
       DoSomething();
    

    With try/catch, it becomes much more verbose.

    try
    {
       PerformCheckSucceeded();
       DoSomething();
    }
    catch
    {
    }
    

    That's 6 lines of code too many.

    0 讨论(0)
  • 2020-11-21 08:05

    There are a few general mechanisms via which a language could allow for a method to exit without returning a value and unwind to the next "catch" block:

    • Have the method examine the stack frame to determine the call site, and use the metadata for the call site to find either information about a try block within the calling method, or the location where the calling method stored the address of its caller; in the latter situation, examine metadata for the caller's caller to determine in the same fashion as the immediate caller, repeating until one finds a try block or the stack is empty. This approach adds very little overhead to the no-exception case (it does preclude some optimizations) but is expensive when an exception occurs.

    • Have the method return a "hidden" flag which distinguishes a normal return from an exception, and have the caller check that flag and branch to an "exception" routine if it's set. This routine adds 1-2 instructions to the no-exception case, but relatively little overhead when an exception occurs.

    • Have the caller place exception-handling information or code at a fixed address relative to the stacked return address. For example, with the ARM, instead of using the instruction "BL subroutine", one could use the sequence:

          adr lr,next_instr
          b subroutine
          b handle_exception
      next_instr:
      

    To exit normally, the subroutine would simply do bx lr or pop {pc}; in case of an abnormal exit, the subroutine would either subtract 4 from LR before performing the return or use sub lr,#4,pc (depending upon the ARM variation, execution mode, etc.) This approach will malfunction very badly if the caller is not designed to accommodate it.

    A language or framework which uses checked exceptions might benefit from having those handled with a mechanism like #2 or #3 above, while unchecked exceptions are handled using #1. Although the implementation of checked exceptions in Java is rather nuisancesome, they would not be a bad concept if there were a means by which a call site could say, essentially, "This method is declared as throwing XX, but I don't expect it ever to do so; if it does, rethrow as an "unchecked" exception. In a framework where checked exceptions were handled in such fashion, they could be an effective means of flow control for things like parsing methods which in some contexts may have a high likelihood of failure, but where failure should return fundamentally different information than success. I'm unaware of any frameworks that use such a pattern, however. Instead, the more common pattern is to use the first approach above (minimal cost for the no-exception case, but high cost when exceptions are thrown) for all exceptions.

    0 讨论(0)
  • 2020-11-21 08:07

    Josh Bloch deals with this topic extensively in Effective Java. His suggestions are illuminating and should apply to .Net as well (except for the details).

    In particular, exceptions should be used for exceptional circumstances. The reasons for this are usability-related, mainly. For a given method to be maximally usable, its input and output conditions should be maximally constrained.

    For example, the second method is easier to use than the first:

    /**
     * Adds two positive numbers.
     *
     * @param addend1 greater than zero
     * @param addend2 greater than zero
     * @throws AdditionException if addend1 or addend2 is less than or equal to zero
     */
    int addPositiveNumbers(int addend1, int addend2) throws AdditionException{
      if( addend1 <= 0 ){
         throw new AdditionException("addend1 is <= 0");
      }
      else if( addend2 <= 0 ){
         throw new AdditionException("addend2 is <= 0");
      }
      return addend1 + addend2;
    }
    
    /**
     * Adds two positive numbers.
     *
     * @param addend1 greater than zero
     * @param addend2 greater than zero
     */
    public int addPositiveNumbers(int addend1, int addend2) {
      if( addend1 <= 0 ){
         throw new IllegalArgumentException("addend1 is <= 0");
      }
      else if( addend2 <= 0 ){
         throw new IllegalArgumentException("addend2 is <= 0");
      }
      return addend1 + addend2;
    }
    

    In either case, you need to check to make sure that the caller is using your API appropriately. But in the second case, you require it (implicitly). The soft Exceptions will still be thrown if the user didn't read the javadoc, but:

    1. You don't need to document it.
    2. You don't need to test for it (depending upon how aggresive your unit testing strategy is).
    3. You don't require the caller to handle three use cases.

    The ground-level point is that Exceptions should not be used as return codes, largely because you've complicated not only YOUR API, but the caller's API as well.

    Doing the right thing comes at a cost, of course. The cost is that everyone needs to understand that they need to read and follow the documentation. Hopefully that is the case anyway.

    0 讨论(0)
提交回复
热议问题