Why is this code invalid in C#?

Question

The following code will not compile:

string foo = \"bar\";
Object o = foo == null ? DBNull.Value : foo;

I get: Error 1 Type of conditio

Answer 1

By the way, your code is a special case that doesn't have to use the conditional operator at all. Instead, the null coalesce operator is more appropriate (but still requires casting):

object result = (object)foo ?? DBNull.Value;

Answer 2

The compiler requires that either the types of second and third operands are the same, or that one is implicitly convertible to the other. In your case, the types are DBNull and string, neither of which is implicitly convertible to the other. Casting either of them to object solves that.

EDIT: Looks like it is indeed legal in Java. Quite how it works out what to do when it comes to method overloading, I'm not sure... I've just looked at the JLS, and it's extremely unclear about what the type of the conditional is when there are two incompatible reference types involved. The C# way of working may be more irritating occasionally, but it's clearer IMO.

The relevant section of the C# 3.0 spec is 7.13, the conditional operator:

The second and third operands of the ?: operator control the type of the conditional expression. Let X and Y be the types of the second and third operands. Then,

• If X and Y are the same type, then this is the type of the conditional
• Otherwise, if an implicit conversion (§6.1) exists from X to Y, but not from Y to X, then Y is the type of the conditional expression.
• Otherwise, if an implicit conversion (§6.1) exists from Y to X, but not from X to Y, then X is the type of the conditional expression.
• Otherwise, no expression type can be determined, and a compile-time error occurs.

Answer 3

DBNull.Value returns type DBNull.

You want the type to be string.

While string can be null it cannot be a DBNull.

In your code the statement on the right of the equals executes before assignment to the object.

Basically if you use:

[condition] ? true value : false value;

In .Net both the true and false options need to be implicitly convertible to the same type, before whatever you assign them to.

This is a result of how C# deals with type-safety. For instance the following is valid:

string item = "item";

var test = item != null ? item : "BLANK";

C#3 doesn't support dynamic types, so what is test? In C# every assignment is also a statement with a return value, so although the var construct is new in C#3 the statement on the right of the equals always has to resolve to a single type.

In C#4 and above you can explicitly support dynamic types, but I don't think that helps here.