So I keep reading everywhere that use of Subject
is \"bad\" - and I kind of agree with the reasoning.
However, I am trying to think of the best way
A simple way to enter the observable is via an Action
private Action<ObservableArgs> _action;
Create the observable
public IObservable<ObservableArgs> GetObservable()
{
return Observable.FromEvent<ObservableArgs>>(
ev => _action += ev,
ev => _action -= ev);
}
Then add to the observable using
public void OnNext(ObservableArgs args)
{
_action?.Invoke(args);
}
It's not so much that the use of Subject<T>
is bad - there has to be some way of "entering the monad" - that's the academic way of saying "get an IObservable<T>
". You need to start somewhere.
The problem with Subject<T>
arises more when it's used from a subscription instead of chaining existing observables together. Subjects should just exist at the edges of your Rx machinery.
If none of the provided entry points (e.g. FromEvent
, FromEventPattern
, FromAsync
, Return
, ToObservable()
and so on) work for you then using Subject<T>
is perfectly valid. And there's no need to add extra complexity just to facilitate using one of the above - most of them use subjects or subject-like constructs under the covers anyway.
In your case, sounds like Subject<T>
is just fine. You might what to look at exposing it via AsObservable() in order to hide the implementation details.