error: void value not ignored as it ought to be

Question

template  Z myTemplate  :: popFromVector ()
{
    if (myVector.empty () == false)
        return myVector.pop_back ();

    return 0;
}

int m         


        

Answer 1

std::vector<T>::pop_back() returns void. You attempt to return it as an int. This is not allowed.

Answer 2

It's the pop_back(). It has a void return type. You have to use back() to get the actual value. This is to avoid unnecessary copies.

Answer 3

That is because the definition of std::vector::pop_back has a void return type ... you are trying to return something from that method, which won't work since that method doesn't return anything.

Change your function to the following so you can return what's there, and remove the back of the vector as well:

template <typename Z> Z myTemplate <Z> :: popFromVector ()
{
    //create a default Z-type object ... this should be a value you can easily
    //recognize as a default null-type, such as 0, etc. depending on the type
    Z temp = Z(); 

    if (myVector.empty () == false)
    {
        temp = myVector.back();
        myVector.pop_back();
        return temp;
    }

    //don't return 0 since you can end-up with a template that 
    //has a non-integral type that won't work for the template return type
    return temp; 
}