New to C++, just wrote this code but wondering if there is an easier way to write this [closed]